linux-kernel - Re: [PATCH] lib: remove back

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAKwvOdnVcXgJtJsVujXpEVOLrY_BU5BPHN4tW_ziXNB-xnZPkw@mail.gmail.com>
Date:   Tue, 5 Apr 2022 11:05:28 -0700
From:   Nick Desaulniers <ndesaulniers@...gle.com>
To:     Tom Rix <trix@...hat.com>,
        Andrew Morton <akpm@...ux-foundation.org>
Cc:     nathan@...nel.org, linux-kernel@...r.kernel.org,
        llvm@...ts.linux.dev
Subject: Re: [PATCH] lib: remove back_str initialization

On Sat, Apr 2, 2022 at 6:16 AM Tom Rix <trix@...hat.com> wrote:
>
> Clang static analysis reports this false positive
> glob.c:48:32: warning: Assigned value is garbage
>   or undefined
>   char const *back_pat = NULL, *back_str = back_str;
>                                 ^~~~~~~~   ~~~~~~~~
>
> back_str is set after back_pat and it's use is
> protected by the !back_pat check.  It is not
> necessary to initialize back_str, so remove
> the initialization.
>

Thanks for the patch!
Reviewed-by: Nick Desaulniers <ndesaulniers@...gle.com>

Andrew, would you mind picking this up for us, please?

> Signed-off-by: Tom Rix <trix@...hat.com>
> ---
>  lib/glob.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lib/glob.c b/lib/glob.c
> index 85ecbda45cd8..15b73f490720 100644
> --- a/lib/glob.c
> +++ b/lib/glob.c
> @@ -45,7 +45,7 @@ bool __pure glob_match(char const *pat, char const *str)
>          * (no exception for /), it can be easily proved that there's
>          * never a need to backtrack multiple levels.
>          */
> -       char const *back_pat = NULL, *back_str = back_str;
> +       char const *back_pat = NULL, *back_str;
>
>         /*
>          * Loop over each token (character or class) in pat, matching
> --
> 2.27.0
>


-- 
Thanks,
~Nick Desaulniers