linux-kernel - Re: [PATCH v5 2/3] KVM: VMX: Enable Notify VM exit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Yk3iAKW1sdA4StiC@google.com>
Date:   Wed, 6 Apr 2022 18:54:56 +0000
From:   Sean Christopherson <seanjc@...gle.com>
To:     Chenyi Qiang <chenyi.qiang@...el.com>
Cc:     Paolo Bonzini <pbonzini@...hat.com>,
        Vitaly Kuznetsov <vkuznets@...hat.com>,
        Wanpeng Li <wanpengli@...cent.com>,
        Jim Mattson <jmattson@...gle.com>,
        Joerg Roedel <joro@...tes.org>,
        Xiaoyao Li <xiaoyao.li@...el.com>, kvm@...r.kernel.org,
        linux-kernel@...r.kernel.org, Tao Xu <tao3.xu@...el.com>
Subject: Re: [PATCH v5 2/3] KVM: VMX: Enable Notify VM exit

On Wed, Apr 06, 2022, Sean Christopherson wrote:
> On Fri, Mar 18, 2022, Chenyi Qiang wrote:
> Ha, and I think skipping this path on VMX_EXIT_REASONS_FAILED_VMENTRY is also
> technically wrong.  That's still a VM-Exit, I'm pretty sure failed VM-Entry only
> skips the MSR load/store list processing (because the load lists on VM-Entry are
> processed after the final consistency checks).

Nope, I'm wrong, the SDM explicit states that only EXIT_QUALIFICATION is modified
on VM-Entry failure VM-Exits.  Which means we actually have the opposite bug as
KVM is clearing a bunch of fields.