linux-kernel - Re: [PATCH net-next RESEND v2 1/3] net: mdio: aspeed: move reg accessing part into separate functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Yk3iw0ENOYUBrXK2@lunn.ch>
Date:   Wed, 6 Apr 2022 20:58:11 +0200
From:   Andrew Lunn <andrew@...n.ch>
To:     Potin Lai <potin.lai@...ntatw.com>
Cc:     Heiner Kallweit <hkallweit1@...il.com>,
        Russell King <linux@...linux.org.uk>, davem@...emloft.net,
        Jakub Kicinski <kuba@...nel.org>,
        Joel Stanley <joel@....id.au>,
        Andrew Jeffery <andrew@...id.au>,
        Patrick Williams <patrick@...cx.xyz>, netdev@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org,
        linux-aspeed@...ts.ozlabs.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next RESEND v2 1/3] net: mdio: aspeed: move reg
 accessing part into separate functions

On Thu, Apr 07, 2022 at 01:00:53AM +0800, Potin Lai wrote:
> Add aspeed_mdio_op() and aseed_mdio_get_data() for register accessing.
> 
> aspeed_mdio_op() handles operations, write command to control register,
> then check and wait operations is finished (bit 31 is cleared).
> 
> aseed_mdio_get_data() fetchs the result value of operation from data
> register.
> 
> Signed-off-by: Potin Lai <potin.lai@...ntatw.com>

Reviewed-by: Andrew Lunn <andrew@...n.ch>

    Andrew