linux-kernel - RE: [PATCH v2 2/2] x86/tsx: Disable TSX development mode at boot

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CO1PR11MB476963E645081B2DE6FB91C88CE79@CO1PR11MB4769.namprd11.prod.outlook.com>
Date:   Wed, 6 Apr 2022 19:13:54 +0000
From:   "Krishnan, Neelima" <neelima.krishnan@...el.com>
To:     Pawan Gupta <pawan.kumar.gupta@...ux.intel.com>,
        Borislav Petkov <bp@...en8.de>
CC:     Thomas Gleixner <tglx@...utronix.de>,
        Ingo Molnar <mingo@...hat.com>,
        Dave Hansen <dave.hansen@...ux.intel.com>,
        "x86@...nel.org" <x86@...nel.org>,
        "H. Peter Anvin" <hpa@...or.com>, Andi Kleen <ak@...ux.intel.com>,
        "Luck, Tony" <tony.luck@...el.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "antonio.gomez.iglesias@...ux.intel.com" 
        <antonio.gomez.iglesias@...ux.intel.com>,
        "stable@...r.kernel.org" <stable@...r.kernel.org>,
        "Cooper, Andrew" <andrew.cooper3@...rix.com>,
        "Poimboe, Josh" <jpoimboe@...hat.com>
Subject: RE: [PATCH v2 2/2] x86/tsx: Disable TSX development mode at boot



-----Original Message-----
From: Pawan Gupta <pawan.kumar.gupta@...ux.intel.com> 
Sent: Tuesday, March 29, 2022 10:28 PM
To: Borislav Petkov <bp@...en8.de>
Cc: Thomas Gleixner <tglx@...utronix.de>; Ingo Molnar <mingo@...hat.com>; Dave Hansen <dave.hansen@...ux.intel.com>; x86@...nel.org; H. Peter Anvin <hpa@...or.com>; Andi Kleen <ak@...ux.intel.com>; Luck, Tony <tony.luck@...el.com>; linux-kernel@...r.kernel.org; antonio.gomez.iglesias@...ux.intel.com; Krishnan, Neelima <neelima.krishnan@...el.com>; stable@...r.kernel.org; Cooper, Andrew <andrew.cooper3@...rix.com>; Poimboe, Josh <jpoimboe@...hat.com>
Subject: Re: [PATCH v2 2/2] x86/tsx: Disable TSX development mode at boot

On Tue, Mar 29, 2022 at 06:24:03PM +0200, Borislav Petkov wrote:
>On Thu, Mar 10, 2022 at 02:02:09PM -0800, Pawan Gupta wrote:
>> A microcode update on some Intel processors causes all TSX 
>> transactions to always abort by default [*]. Microcode also added 
>> functionality to re-enable TSX for development purpose. With this 
>> microcode loaded, if tsx=on was passed on the cmdline, and TSX 
>> development mode was already enabled before the kernel boot, it may 
>> make the system vulnerable to TSX Asynchronous Abort (TAA).
>>
>> To be on safer side, unconditionally disable TSX development mode at 
>> boot. If needed, a user can enable it using msr-tools.
>>
>> [*] Intel Transactional Synchronization Extension (Intel TSX) Disable Update for Selected Processors
>>     https://cdrdv2.intel.com/v1/dl/getContent/643557
>>
>> Suggested-by: Andrew Cooper <andrew.cooper3@...rix.com>
>> Suggested-by: Borislav Petkov <bp@...en8.de>
>> Signed-off-by: Pawan Gupta <pawan.kumar.gupta@...ux.intel.com>
>> Cc: <stable@...r.kernel.org>
>> ---
>>  arch/x86/include/asm/msr-index.h       |  4 +--
>>  arch/x86/kernel/cpu/cpu.h              |  1 +
>>  arch/x86/kernel/cpu/intel.c            |  4 +++
>>  arch/x86/kernel/cpu/tsx.c              | 34 ++++++++++++++++++++++++++
>>  tools/arch/x86/include/asm/msr-index.h |  4 +--
>>  5 files changed, 43 insertions(+), 4 deletions(-)
>
>Does this a lot more encapsulated version work too?

>Neelima is testing this patch, she will share the results tomorrow.

Following up on this email thread, I did some basic functional validation of the patch[1]. 
Initially I ran into the bug where the mitigation was getting disabled in one CPU after a suspend/resume [2]. 
But after applying the patch [1] on latest upstream, with the fix for restoring speculation related MSRs during s3 resume [2], my tests are passing. 

Quick summary of testcases executed:
Testcase 1:  Verify RTM_ALLOW was getting reset after kexec reboot
Testcase2: Verify TSX_CTRL_MSR is restored after system goes to S3 suspend state

[1] https://lore.kernel.org/lkml/YkMyo2Jw8iYx9wAU@zn.tnic/
[2] https://github.com/torvalds/linux/commit/e2a1256b17b16f9b9adf1b6fea56819e7b68e463

Thanks
Neelima