linux-kernel - Re: [PATCH v2] selftest/vm clarify error statement in gup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c0ba950a-9210-1a73-dc6b-6655fcda9878@linuxfoundation.org>
Date:   Wed, 6 Apr 2022 13:35:25 -0600
From:   Shuah Khan <skhan@...uxfoundation.org>
To:     Sidhartha Kumar <sidhartha.kumar@...cle.com>, shuah@...nel.org,
        akpm@...ux-foundation.org
Cc:     linux-mm@...ck.org, linux-kselftest@...r.kernel.org,
        linux-kernel@...r.kernel.org,
        Shuah Khan <skhan@...uxfoundation.org>
Subject: Re: [PATCH v2] selftest/vm clarify error statement in gup_test

On 4/5/22 3:48 PM, Sidhartha Kumar wrote:
> Print three possible reasons /sys/kernel/debug/gup_test
> cannot be opened to help users of this test diagnose
> failures.
> 
> Signed-off-by: Sidhartha Kumar <sidhartha.kumar@...cle.com>
> ---
> v2:
> - Add support for skipping the test due to unmet dependencies.
> - Use errno to print a more specific message.
> - Add check for root privileges.
> - dropped CC to stable.
>   tools/testing/selftests/vm/gup_test.c     | 22 +++++++++++++--
>   tools/testing/selftests/vm/run_vmtests.sh | 33 ++++++++++++++++-------
>   2 files changed, 44 insertions(+), 11 deletions(-)
> 

Thank you for fixing the reporting and adding tests for dependencies
and skip conditions.

Reviewed-by: Shuah Khan <skhan@...uxfoundation.org>

thanks,
-- Shuah