Date:   Thu, 7 Apr 2022 04:46:05 +0800
From:   kernel test robot <lkp@...el.com>
To:     David Howells <dhowells@...hat.com>
Cc:     llvm@...ts.linux.dev, kbuild-all@...ts.01.org,
        GNU/Weeb Mailing List <gwml@...r.gnuweeb.org>,
        linux-kernel@...r.kernel.org
Subject: [ammarfaizi2-block:dhowells/linux-fs/fscache-ceph 22/22]
 fs/ceph/addr.c:1047:9: error: use of undeclared identifier 'skips'

tree:   https://github.com/ammarfaizi2/linux-block dhowells/linux-fs/fscache-ceph
head:   3eaf3110a87879d1fdaf472fd14885c99aa919a0
commit: 3eaf3110a87879d1fdaf472fd14885c99aa919a0 [22/22] ceph: Pass an iter down from writepages
config: hexagon-randconfig-r014-20220406 (https://download.01.org/0day-ci/archive/20220407/202204070429.h8hMgEQm-lkp@intel.com/config)
compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project c4a1b07d0979e7ff20d7d541af666d822d66b566)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/ammarfaizi2/linux-block/commit/3eaf3110a87879d1fdaf472fd14885c99aa919a0
        git remote add ammarfaizi2-block https://github.com/ammarfaizi2/linux-block
        git fetch --no-tags ammarfaizi2-block dhowells/linux-fs/fscache-ceph
        git checkout 3eaf3110a87879d1fdaf472fd14885c99aa919a0
        # save the config file to linux build tree
        mkdir build_dir
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=hexagon SHELL=/bin/bash fs/ceph/

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>

All errors (new ones prefixed by >>):

>> fs/ceph/addr.c:1047:9: error: use of undeclared identifier 'skips'
                                   if (skips >= 5 || need_resched())
                                       ^
   fs/ceph/addr.c:1049:5: error: use of undeclared identifier 'skips'
                                   skips++;
                                   ^
   2 errors generated.


vim +/skips +1047 fs/ceph/addr.c

   982	
   983	/*
   984	 * write a region of pages back to the server
   985	 */
   986	static int ceph_writepages_region(struct address_space *mapping,
   987					  struct writeback_control *wbc,
   988					  struct ceph_snap_context *snapc,
   989					  struct ceph_writeback_ctl *ceph_wbc,
   990					  loff_t start, loff_t end, loff_t *_next)
   991	{
   992		struct folio *folio;
   993		ssize_t ret;
   994	
   995		printk("%s(%llx,%llx)", __func__, start, end);
   996	
   997		do {
   998			pgoff_t index = start / PAGE_SIZE;
   999			pgoff_t end = end / PAGE_SIZE;
  1000	
  1001			folio = ceph_scan_for_writeable_page(mapping, snapc, index, end);
  1002			if (!folio)
  1003				break;
  1004	
  1005			start = folio_pos(folio); /* May regress with THPs */
  1006	
  1007			printk("wback %lx\n", folio_index(folio));
  1008	
  1009			/* At this point we hold neither the i_pages lock nor the
  1010			 * page lock: the page may be truncated or invalidated
  1011			 * (changing page->mapping to NULL), or even swizzled
  1012			 * back from swapper_space to tmpfs file mapping
  1013			 */
  1014			if (wbc->sync_mode != WB_SYNC_NONE) {
  1015				ret = folio_lock_killable(folio);
  1016				if (ret < 0) {
  1017					folio_put(folio);
  1018					return ret;
  1019				}
  1020			} else {
  1021				if (!folio_trylock(folio)) {
  1022					folio_put(folio);
  1023					return 0;
  1024				}
  1025			}
  1026	
  1027			if (folio_mapping(folio) != mapping ||
  1028			    folio_get_private(folio) != snapc ||
  1029			    !folio_test_dirty(folio)) {
  1030				start += folio_size(folio);
  1031				folio_unlock(folio);
  1032				folio_put(folio);
  1033				continue;
  1034			}
  1035	
  1036			if (folio_test_writeback(folio) ||
  1037			    folio_test_fscache(folio)) {
  1038				folio_unlock(folio);
  1039				if (wbc->sync_mode != WB_SYNC_NONE) {
  1040					folio_wait_writeback(folio);
  1041					folio_wait_fscache(folio);
  1042				} else {
  1043					start += folio_size(folio);
  1044				}
  1045				folio_put(folio);
  1046				if (wbc->sync_mode == WB_SYNC_NONE) {
> 1047					if (skips >= 5 || need_resched())
  1048						break;
  1049					skips++;
  1050				}
  1051				continue;
  1052			}
  1053	
  1054			if (!folio_clear_dirty_for_io(folio))
  1055				BUG();
  1056			ret = ceph_write_back_from_locked_folio(mapping, wbc, snapc, ceph_wbc,
  1057								folio, start, end);
  1058			folio_put(folio);
  1059			if (ret < 0)
  1060				return ret;
  1061	
  1062			start += ret;
  1063	
  1064			cond_resched();
  1065		} while (wbc->nr_to_write > 0);
  1066	
  1067		*_next = start;
  1068		printk("%s() = 0 [%llx]\n", __func__, *_next);
  1069		return 0;
  1070	}
  1071	

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp

Powered by blists - more mailing lists