linux-kernel - Re: [RFC PATCH v5 029/104] KVM: TDX: allocate/free TDX vcpu structure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a02a704a-e53d-6f1f-cd7f-a10b773475cc@redhat.com>
Date:   Tue, 5 Apr 2022 15:04:10 +0200
From:   Paolo Bonzini <pbonzini@...hat.com>
To:     isaku.yamahata@...el.com, kvm@...r.kernel.org,
        linux-kernel@...r.kernel.org
Cc:     isaku.yamahata@...il.com, Jim Mattson <jmattson@...gle.com>,
        erdemaktas@...gle.com, Connor Kuehl <ckuehl@...hat.com>,
        Sean Christopherson <seanjc@...gle.com>
Subject: Re: [RFC PATCH v5 029/104] KVM: TDX: allocate/free TDX vcpu structure

On 3/4/22 20:48, isaku.yamahata@...el.com wrote:
> +	/*
> +	 * In TDX case, tsc frequency is per-VM and determined by the parameter
> +	 * tdh_mng_init().  Forcibly set it instead of max_tsc_khz set by
> +	 * kvm_arch_vcpu_create().
> +	 *
> +	 * This function is called after kvm_arch_vcpu_create() calling
> +	 * kvm_set_tsc_khz().
> +	 */
> +	kvm_set_tsc_khz(vcpu, kvm_tdx->tsc_khz);
> +

I think this is not needed anymore, now that there is 
kvm->arch.default_tsc_khz.  If so, exporting the function is not needed 
either.

Paolo