linux-kernel - Re: [ovs-dev] [PATCH net] net: openvswitch: don't send internal clone attribute to the userspace.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f7tzgkzznz6.fsf@redhat.com>
Date:   Tue, 05 Apr 2022 08:58:05 -0400
From:   Aaron Conole <aconole@...hat.com>
To:     Ilya Maximets <i.maximets@....org>
Cc:     netdev@...r.kernel.org, dev@...nvswitch.org,
        linux-kernel@...r.kernel.org, Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>,
        "David S. Miller" <davem@...emloft.net>
Subject: Re: [ovs-dev] [PATCH net] net: openvswitch: don't send internal
 clone attribute to the userspace.

Ilya Maximets <i.maximets@....org> writes:

> 'OVS_CLONE_ATTR_EXEC' is an internal attribute that is used for
> performance optimization inside the kernel.  It's added by the kernel
> while parsing user-provided actions and should not be sent during the
> flow dump as it's not part of the uAPI.
>
> The issue doesn't cause any significant problems to the ovs-vswitchd
> process, because reported actions are not really used in the
> application lifecycle and only supposed to be shown to a human via
> ovs-dpctl flow dump.  However, the action list is still incorrect
> and causes the following error if the user wants to look at the
> datapath flows:
>
>   # ovs-dpctl add-dp system@...-system
>   # ovs-dpctl add-flow "<flow match>" "clone(ct(commit),0)"
>   # ovs-dpctl dump-flows
>   <flow match>, packets:0, bytes:0, used:never,
>     actions:clone(bad length 4, expected -1 for: action0(01 00 00 00),
>                   ct(commit),0)
>
> With the fix:
>
>   # ovs-dpctl dump-flows
>   <flow match>, packets:0, bytes:0, used:never,
>     actions:clone(ct(commit),0)
>
> Additionally fixed an incorrect attribute name in the comment.
>
> Fixes: b233504033db ("openvswitch: kernel datapath clone action")
> Signed-off-by: Ilya Maximets <i.maximets@....org>
> ---

Acked-by: Aaron Conole <aconole@...hat.com>