linux-kernel - Re: [PATCH] drm/amdgpu: Junk code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CADnq5_Mf3hpqnbgywSD68CmUe3dYrwjdZpFaMDrMWazDxBFWcg@mail.gmail.com>
Date:   Tue, 5 Apr 2022 09:56:10 -0400
From:   Alex Deucher <alexdeucher@...il.com>
To:     Grigory Vasilyev <h0tc0d3@...il.com>
Cc:     Rodrigo Siqueira <Rodrigo.Siqueira@....com>,
        Melissa Wen <mwen@...lia.com>,
        "Pan, Xinhui" <Xinhui.Pan@....com>,
        LKML <linux-kernel@...r.kernel.org>,
        amd-gfx list <amd-gfx@...ts.freedesktop.org>,
        David Airlie <airlied@...ux.ie>,
        Claudio Suarez <cssk@...-c.es>,
        Maling list - DRI developers 
        <dri-devel@...ts.freedesktop.org>,
        Alex Deucher <alexander.deucher@....com>,
        Christian König <christian.koenig@....com>
Subject: Re: [PATCH] drm/amdgpu: Junk code

On Tue, Apr 5, 2022 at 5:07 AM Grigory Vasilyev <h0tc0d3@...il.com> wrote:
>
> Variable igp_lane_info always is 0. 0 & any value = 0 and false.
> In this way, all сonditional statements will false.
> Therefore, it is not clear what this code does.

It was leftover from when the code was ported from radeon.  The igp
lane info was available from the vbios on older APUs.  It's not
relevant on any asics supported by amdgpu.  I've applied the patch and
clarified the commit message.

Thanks,

Alex

>
> Signed-off-by: Grigory Vasilyev <h0tc0d3@...il.com>
> ---
>  .../gpu/drm/amd/amdgpu/atombios_encoders.c    | 21 -------------------
>  1 file changed, 21 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/atombios_encoders.c b/drivers/gpu/drm/amd/amdgpu/atombios_encoders.c
> index 2b0cc793291c..100bad2f5901 100644
> --- a/drivers/gpu/drm/amd/amdgpu/atombios_encoders.c
> +++ b/drivers/gpu/drm/amd/amdgpu/atombios_encoders.c
> @@ -769,7 +769,6 @@ amdgpu_atombios_encoder_setup_dig_transmitter(struct drm_encoder *encoder, int a
>         int dp_clock = 0;
>         int dp_lane_count = 0;
>         int connector_object_id = 0;
> -       int igp_lane_info = 0;
>         int dig_encoder = dig->dig_encoder;
>         int hpd_id = AMDGPU_HPD_NONE;
>
> @@ -852,26 +851,6 @@ amdgpu_atombios_encoder_setup_dig_transmitter(struct drm_encoder *encoder, int a
>                         else
>                                 args.v1.ucConfig |= ATOM_TRANSMITTER_CONFIG_DIG1_ENCODER;
>
> -                       if ((adev->flags & AMD_IS_APU) &&
> -                           (amdgpu_encoder->encoder_id == ENCODER_OBJECT_ID_INTERNAL_UNIPHY)) {
> -                               if (is_dp ||
> -                                   !amdgpu_dig_monitor_is_duallink(encoder, amdgpu_encoder->pixel_clock)) {
> -                                       if (igp_lane_info & 0x1)
> -                                               args.v1.ucConfig |= ATOM_TRANSMITTER_CONFIG_LANE_0_3;
> -                                       else if (igp_lane_info & 0x2)
> -                                               args.v1.ucConfig |= ATOM_TRANSMITTER_CONFIG_LANE_4_7;
> -                                       else if (igp_lane_info & 0x4)
> -                                               args.v1.ucConfig |= ATOM_TRANSMITTER_CONFIG_LANE_8_11;
> -                                       else if (igp_lane_info & 0x8)
> -                                               args.v1.ucConfig |= ATOM_TRANSMITTER_CONFIG_LANE_12_15;
> -                               } else {
> -                                       if (igp_lane_info & 0x3)
> -                                               args.v1.ucConfig |= ATOM_TRANSMITTER_CONFIG_LANE_0_7;
> -                                       else if (igp_lane_info & 0xc)
> -                                               args.v1.ucConfig |= ATOM_TRANSMITTER_CONFIG_LANE_8_15;
> -                               }
> -                       }
> -
>                         if (dig->linkb)
>                                 args.v1.ucConfig |= ATOM_TRANSMITTER_CONFIG_LINKB;
>                         else
> --
> 2.35.1
>