linux-kernel - Re: [PATCH v2] Documentation: x86: Fix obsolete name of page fault handler

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 05 Apr 2022 10:30:16 -0600
From:   Jonathan Corbet <corbet@....net>
To:     Chin En Lin <shiyn.lin@...il.com>
Cc:     tglx@...utronix.de, mingo@...hat.com, bp@...en8.de,
        dave.hansen@...ux.intel.com, x86@...nel.org, hpa@...or.com,
        linux-kernel@...r.kernel.org, linux-doc@...r.kernel.org,
        Chin En Lin <shiyn.lin@...il.com>
Subject: Re: [PATCH v2] Documentation: x86: Fix obsolete name of page fault
 handler

Chin En Lin <shiyn.lin@...il.com> writes:

> Since commit 91eeafea1e4b ("x86/entry: Switch page fault exception to
> IDTENTRY_RAW"), the function name of the page fault handler is out of date.
> And because of commit aa37c51b9421 ("x86/mm: Break out user address space
> handling"), the description of search_exception_table is not correct
> anymore. It may mislead the user who wants to use the documentation to
> figure out the page fault handler.
>
> Also, fix typo and add the parentheses after function and macro name.

"Also" in a changelog like this is an indication that you've moved on to
an independent change that should be done as its own patch.  That is
certainly true of typo fixes and such, which should be separated out
from more substantive changes.

> Signed-off-by: Chin En Lin <shiyn.lin@...il.com>
> ---
>  Documentation/x86/exception-tables.rst | 23 +++++++++++++----------
>  1 file changed, 13 insertions(+), 10 deletions(-)

Nonetheless, the patch seems clear enough and nobody has objected, so
I've applied it.

Thanks,

jon