linux-kernel - Re: [PATCH v2] staging: rtl8723bs: fix indentation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 5 Apr 2022 17:58:30 +0200
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Sevinj Aghayeva <sevinj.aghayeva@...il.com>
Cc:     linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org,
        outreachy linux kernel <outreachy@...ts.linux.dev>
Subject: Re: [PATCH v2] staging: rtl8723bs: fix indentation

On Tue, Apr 05, 2022 at 11:45:29AM -0400, Sevinj Aghayeva wrote:
> On Tue, Apr 5, 2022 at 11:19 AM Sevinj Aghayeva
> <sevinj.aghayeva@...il.com> wrote:
> >
> > On Tue, Apr 5, 2022 at 11:17 AM Greg Kroah-Hartman
> > <gregkh@...uxfoundation.org> wrote:
> > >
> > > On Tue, Apr 05, 2022 at 11:09:12AM -0400, Sevinj Aghayeva wrote:
> > > > Adhere to Linux kernel coding style.
> > > >
> > > > Reported by checkpatch:
> > > >
> > > > WARNING: suspect code indent for conditional statements
> > >
> > > You are also removing unneeded comments, right?  Please explain that as
> > > the documentation link the bot pointed you to showed.
> >
> > I specified that under the --- line:
> >
> > v1 -> v2: Remove the comments that became irrelevant with proper indentation.
> 
> I think I misunderstood the bot's response. It looks like you
> triggered it because you wanted me to write a more complete
> description of what the commit is doing. I thought I received it
> because it was the second version of the patch from a previous
> patchset (the last bullet point in the bot response) that didn't
> include v2 in the subject and a v1 -> v2 after the --- line.

That is one reason, yes, but you also need to update the changelog text
to say everything you are doing in the commit.

> I can do a fresh patch with a complete description and no v2 stuff;
> please let me know.

It will be a v3 patch, right?

thanks,

greg k-h