linux-kernel - Re: [PATCH v2] staging: media: ipu3: Fix AWB x_start position when rightmost stripe is used

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220407132609.GN3293@kadam>
Date:   Thu, 7 Apr 2022 16:26:09 +0300
From:   Dan Carpenter <dan.carpenter@...cle.com>
To:     Kate Hsuan <hpa@...hat.com>
Cc:     Sakari Ailus <sakari.ailus@...ux.intel.com>,
        Bingbu Cao <bingbu.cao@...el.com>,
        Tianshu Qiu <tian.shu.qiu@...el.com>,
        Mauro Carvalho Chehab <mchehab@...nel.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Jean-Michel Hautbois <jeanmichel.hautbois@...asonboard.com>,
        linux-media@...r.kernel.org, linux-staging@...ts.linux.dev,
        linux-kernel@...r.kernel.org, Hans De Goede <hdegoede@...hat.com>
Subject: Re: [PATCH v2] staging: media: ipu3: Fix AWB x_start position when
 rightmost stripe is used

On Thu, Apr 07, 2022 at 09:17:38PM +0800, Kate Hsuan wrote:
> Hi Dan,
> 
> On Thu, Apr 7, 2022 at 7:52 PM Dan Carpenter <dan.carpenter@...cle.com> wrote:
> >
> > On Thu, Apr 07, 2022 at 06:57:24PM +0800, Kate Hsuan wrote:
> > > A not calibrated x_start setting would result in an incorrect AWB location
> > > configuration on a sensor when only the rightmost stripe is used. x_start
> > > should be calibrated by subtracting the stripe offset to set the coordinate
> > > to the correct position on the second stripe.
> > >
> 
> >
> > I wish the commit description said more about what the bug looks like to
> > the user.  This is the front facing camera, right?  Is part of the video
> > blank or what's the deal?
> 
> This is IPU3 image processor. I tried to fix the configuration issues
> on stripe 1 coordinate settings.
> 

So in terms of users, if you configure it in a certain way then it
crashes?  What happens in terms of what the ordinary user sees?

regards,
dan carpenter