linux-kernel - Re: [PATCH v3] libata: Improve ATA queued command allocation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20220407133232.GA7092@lst.de>
Date:   Thu, 7 Apr 2022 15:32:32 +0200
From:   Christoph Hellwig <hch@....de>
To:     John Garry <john.garry@...wei.com>
Cc:     damien.lemoal@...nsource.wdc.com, hch@....de,
        linux-doc@...r.kernel.org, linux-ide@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3] libata: Improve ATA queued command allocation

> +	qc = __ata_qc_from_tag(ap, tag);
> +	qc->tag = qc->hw_tag = tag;
> +	qc->scsicmd = NULL;
> +	qc->ap = ap;
> +	qc->dev = dev;
> +
> +	ata_qc_reinit(qc);
> +
> +	qc->scsicmd = cmd;

My fault, byt we can remove the first qc->scsicmd a nothing looks
at the field before this real initialization.

Otherwise looks good:

Reviewed-by: Christoph Hellwig <hch@....de>