linux-kernel - Re: [PATCH v7 0/1] firmware: mtk: add adsp ipc protocol for SOF

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Yk701wLNKQs1DEVx@makrotopia.org>
Date:   Thu, 7 Apr 2022 15:27:35 +0100
From:   Daniel Golle <daniel@...rotopia.org>
To:     Allen-KH Cheng <allen-kh.cheng@...iatek.com>
Cc:     Matthias Brugger <matthias.bgg@...il.com>,
        Mark Brown <broonie@...nel.org>,
        linux-arm-kernel@...ts.infradead.org, devicetree@...r.kernel.org,
        Linux-ALSA <alsa-devel@...a-project.org>,
        Kai Vehmanen <kai.vehmanen@...ux.intel.com>,
        cujomalainey@...gle.com, Kevin Hilman <khilman@...libre.com>,
        Takashi Iwai <tiwai@...e.com>,
        Pierre-Louis Bossart <pierre-louis.bossart@...ux.intel.com>,
        Liam Girdwood <lgirdwood@...il.com>,
        Project_Global_Chrome_Upstream_Group@...iatek.com,
        tzungbi@...gle.com, linux-mediatek@...ts.infradead.org,
        Ranjani Sridharan <ranjani.sridharan@...ux.intel.com>,
        Chen-Yu Tsai <wenst@...omium.org>,
        Daniel Baluta <daniel.baluta@....com>,
        linux-kernel@...r.kernel.org, sound-open-firmware@...a-project.org
Subject: Re: [PATCH v7 0/1] firmware: mtk: add adsp ipc protocol for SOF

On Thu, Apr 07, 2022 at 09:03:37PM +0800, Allen-KH Cheng wrote:
> This patch provides mediatek adsp ipc support for SOF.
> ADSP IPC protocol offers (send/recv) interfaces using
> mediatek-mailbox APIs.
> 
> This patch was tested and confirmed to with SOF fw on MT8195
> cherry board.

... confirmed to **work** with ...
is probably what you meant to write here.


> 
> Based on matthias.bgg/linux.git, v5.18-next/soc
> changes since v6:
> - rebase to matthias.bgg/linux.git, v5.18-next/soc
> - Prefer "GPL" over "GPL v2" for MODULE_LICENSE
> 
> changes since v5:
> - fix WARNING: modpost: missing MODULE_LICENSE() in drivers/mailbox
>   /mtk-adsp-mailbox.o. Add MODULE_LICENSE in the last line.
> - Due to WARNING: Missing or malformed SPDX-License-Identifier tag
>   in line 1 in checkpatch, we don't remove SPDX-License in line 1.
> 
> changes since v4:
> - add error message for wrong mbox chan
> 
> changes since v3:
> - rebase on v5.16-rc8
> - update reviewers
> 
> changes since v2:
> - add out tag for two memory free phases
> 
> changes since v1:
> - add comments for mtk_adsp_ipc_send and mtk_adsp_ipc_recv
> - remove useless MODULE_LICENSE
> - change label name to out_free
> 
> 
> Allen-KH Cheng (1):
>   firmware: mediatek: add adsp ipc protocol interface
> 
>  drivers/firmware/Kconfig                      |   1 +
>  drivers/firmware/Makefile                     |   1 +
>  drivers/firmware/mediatek/Kconfig             |   9 +
>  drivers/firmware/mediatek/Makefile            |   2 +
>  drivers/firmware/mediatek/mtk-adsp-ipc.c      | 161 ++++++++++++++++++
>  .../linux/firmware/mediatek/mtk-adsp-ipc.h    |  65 +++++++
>  6 files changed, 239 insertions(+)
>  create mode 100644 drivers/firmware/mediatek/Kconfig
>  create mode 100644 drivers/firmware/mediatek/Makefile
>  create mode 100644 drivers/firmware/mediatek/mtk-adsp-ipc.c
>  create mode 100644 include/linux/firmware/mediatek/mtk-adsp-ipc.h
> 
> -- 
> 2.18.0
>