linux-kernel - Re: [PATCH] ASoC: rt5682: Add jack kcontrol

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <96dae189-c0ff-4054-3d00-41c3b44c2cd6@gmail.com>
Date:   Fri, 8 Apr 2022 00:46:04 +0900
From:   Akihiko Odaki <akihiko.odaki@...il.com>
To:     Mark Brown <broonie@...nel.org>
Cc:     alsa-devel@...a-project.org, linux-kernel@...r.kernel.org,
        Jaroslav Kysela <perex@...ex.cz>,
        Oder Chiou <oder_chiou@...ltek.com>,
        Liam Girdwood <lgirdwood@...il.com>
Subject: Re: [PATCH] ASoC: rt5682: Add jack kcontrol

On 2022/04/08 0:09, Mark Brown wrote:
> On Thu, Apr 07, 2022 at 11:13:16PM +0900, Akihiko Odaki wrote:
> 
>> Create a jack kcontrol manually as rt5682 does not use DAPM pins
>> for jack and will not have kcontrols for them.
> 
> Why not use DAPM for the jack?  Note that normally the jack is part of
> the machine driver not the CODEC - there's no way the CODEC can know how
> it's been wired in on any given system.

It seems it is an unsual case where the codec knows the source of the 
jack. RT5682 has interrupts and registers for the jack; see e.g. 
rt5682_button_detect in sound/soc/codecs/rt5682.c for details.

Regards,
Akihiko Odaki