linux-kernel - Re: [RFC PATCH v5 091/104] KVM: TDX: Handle TDX PV CPUID hypercall

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6558fe13-6406-7536-7557-e89a8b10d102@redhat.com>
Date:   Thu, 7 Apr 2022 20:03:37 +0200
From:   Paolo Bonzini <pbonzini@...hat.com>
To:     Sean Christopherson <seanjc@...gle.com>
Cc:     isaku.yamahata@...el.com, kvm@...r.kernel.org,
        linux-kernel@...r.kernel.org, isaku.yamahata@...il.com,
        Jim Mattson <jmattson@...gle.com>, erdemaktas@...gle.com,
        Connor Kuehl <ckuehl@...hat.com>
Subject: Re: [RFC PATCH v5 091/104] KVM: TDX: Handle TDX PV CPUID hypercall

On 4/7/22 16:48, Sean Christopherson wrote:
>> Reviewed-by: Paolo Bonzini<pbonzini@...hat.com>
>>
>> but I don't think tdvmcall_*_{read,write} add much.
> They provided a lot more value when the ABI was still in flux, but I still like
> having them.  That said, either the comments about R12..R15 need to go, or the
> wrappers need to go.  Having both is confusing.
> 

Fair enough, let's keep them but rename them a0..a3 for consistency with 
kvm_emulate_hypercall.

Paolo