linux-kernel - Re: [PATCH v4] staging: rtl8712: remove unnecessary parentheses

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Yk8tVxot2znwyWLm@kroah.com>
Date:   Thu, 7 Apr 2022 20:28:39 +0200
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Alaa Mohamed <eng.alaamohamedsoliman.am@...il.com>
Cc:     outreachy@...ts.linux.dev, Larry.Finger@...inger.net,
        florian.c.schilhabel@...glemail.com, linux-staging@...ts.linux.dev,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4] staging: rtl8712: remove unnecessary parentheses

On Thu, Apr 07, 2022 at 08:02:37PM +0200, Alaa Mohamed wrote:
> 
> On ٧‏/٤‏/٢٠٢٢ ١٩:٤٦, Greg KH wrote:
> > On Thu, Apr 07, 2022 at 02:59:47PM +0200, Alaa Mohamed wrote:
> > > Reported by checkpatch:
> > > 
> > > Remove unnecessary parentheses around structure field references
> > > 
> > > Signed-off-by: Alaa Mohamed <eng.alaamohamedsoliman.am@...il.com>
> > > ---
> > > Changes in v2:
> > > 	- Edit commit subject
> > > 	- Edit commit message
> > > 	- Fix the same check in more lines
> > > 	- Remove space before '.skey' in
> > > "memcpy(psta->tkiptxmickey.skey," in lines 84 and 86.
> > > ---
> > > Changes in v3:
> > > 	return the space before '.skey' in
> > > "memcpy(psta->tkiptxmickey.skey," in lines 84 and 86
> > > ---
> > > Changes in v4:
> > > 	edit commit message to be clearer.
> > > ---
> > Why did you send this patch twice?
> That was by mistake , sorry

When you do so, please let us know which to take, as it is hard to know
if there was a difference or not.

Realize that for some of us, we get hundreds of patches to review daily.
Being obvious as to what to, and not to, ignore, is helpful.

thanks,

greg k-h