linux-kernel - Re: [PATCH] qed: remove an unneed NULL check on list iterator

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu,  7 Apr 2022 09:22:07 +0800
From:   Xiaomeng Tong <xiam0nd.tong@...il.com>
To:     kuba@...nel.org
Cc:     aelior@...vell.com, davem@...emloft.net,
        linux-kernel@...r.kernel.org, manishc@...vell.com,
        netdev@...r.kernel.org, pabeni@...hat.com, xiam0nd.tong@...il.com
Subject: Re: [PATCH] qed: remove an unneed NULL check on list iterator

On Tue, 5 Apr 2022 18:26:41 -0700, Jakub Kicinski wrote:
> On Tue,  5 Apr 2022 08:22:56 +0800 Xiaomeng Tong wrote:
> >  struct pci_dev *qed_validate_ndev(struct net_device *ndev)
> >  {
> > -	struct pci_dev *pdev = NULL;
> > +	struct pci_dev *pdev;
> >  	struct net_device *upper;
> 
> Please keep the longest-to-shortest ordering of variable declaration
> lines.

I have fix it in v2 patch [1], as you suggested. Please check it.
Thank you very much.

[1] https://lore.kernel.org/lkml/20220406015921.29267-1-xiam0nd.tong@gmail.com/
--
Xiaomeng Tong