linux-kernel - Re: [PATCH 1/3] dt-bindings: PCI: designware-ep: Increase maxItems of reg and reg-names

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <b7cd4fe0-5d61-322a-b42a-d239ee23b201@socionext.com>
Date:   Thu, 7 Apr 2022 09:51:09 +0900
From:   Kunihiko Hayashi <hayashi.kunihiko@...ionext.com>
To:     Rob Herring <robh@...nel.org>
Cc:     Jingoo Han <jingoohan1@...il.com>,
        Gustavo Pimentel <gustavo.pimentel@...opsys.com>,
        Bjorn Helgaas <bhelgaas@...gle.com>,
        Krzysztof Kozlowski <krzk+dt@...nel.org>,
        Masami Hiramatsu <mhiramat@...nel.org>,
        linux-pci@...r.kernel.org, devicetree@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/3] dt-bindings: PCI: designware-ep: Increase maxItems of
 reg and reg-names

Hi Rob,
Thank you for pointing out.

On 2022/04/07 3:14, Rob Herring wrote:
> On Tue, Apr 05, 2022 at 04:51:00PM +0900, Kunihiko Hayashi wrote:
>> UniPhier PCIe EP controller has 5 register mappings (dbi, dbi2, link,
>> config and atu), so maxItems of "reg" and "reg-names" should allow 5.
> 
> Shouldn't that be 'addr_space' rather than 'config'? IIRC, 'config' is
> only for the host.

Yes. I made a mistake in the comment.
UniPhier EP controller has also "addr_space", not "config".
I'll fix it next.

Thank you,

---
Best Regards
Kunihiko Hayashi