linux-kernel - Re: [PATCH v2 2/2] staging: r8188eu: check the return of kzalloc()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <tencent_0D5C6E0E160AA0702025FDFF35906EE69E07@qq.com>
Date:   Thu, 7 Apr 2022 10:03:49 +0800
From:   <xkernel.wang@...mail.com>
To:     <paskripkin@...il.com>
Cc:     <gregkh@...uxfoundation.org>, <Larry.Finger@...inger.net>,
        <phil@...lpotter.co.uk>, <linux-staging@...ts.linux.dev>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2 2/2] staging: r8188eu: check the return of kzalloc()

On Thursday, April 7, 2022 3:22 AM +0800, paskripkin@...il.com wrote:
> > -void rtw_alloc_hwxmits(struct adapter *padapter)
> > +s32 rtw_alloc_hwxmits(struct adapter *padapter)
> >   {
> 
> What about plain 'int'? I know that s32 is typedef for 'int', but 'int'
> looks more natural
> 

I agree with you.
Since the type of `_rtw_init_xmit_priv` is `s32`, I directly changed the
type of `rtw_alloc_hwxmits` to `s32` (they are neighbors in rtw_xmit.h).
In fact, there are many places where `s32` appears together with `int` 
in related files, so maybe we can leave it as a future work to make all 
of them a unified form.

Regards,
Xiaoke Wang