linux-kernel - Re: [PATCH] fpga: altera-pr-ip: fix unsigned comparison with less than zero

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220407020935.GA256292@yilunxu-OptiPlex-7050>
Date:   Thu, 7 Apr 2022 10:09:35 +0800
From:   Xu Yilun <yilun.xu@...el.com>
To:     Tom Rix <trix@...hat.com>
Cc:     Marco Pagani <marpagan@...hat.com>,
        Moritz Fischer <mdf@...nel.org>, Wu Hao <hao.wu@...el.com>,
        linux-fpga@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] fpga: altera-pr-ip: fix unsigned comparison with less
  than zero

On Wed, Apr 06, 2022 at 07:18:21AM -0700, Tom Rix wrote:
> 
> On 4/5/22 11:53 AM, Marco Pagani wrote:
> > Fix the "comparison with less than zero" warning reported by
> > cppcheck for the unsigned (size_t) parameter "count" of the
> > "alt_pr_fpga_write()" function.
> > 
> > Signed-off-by: Marco Pagani <marpagan@...hat.com>
> > ---
> >   drivers/fpga/altera-pr-ip-core.c | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/fpga/altera-pr-ip-core.c b/drivers/fpga/altera-pr-ip-core.c
> > index be0667968d33..2ff3d8e46a0c 100644
> > --- a/drivers/fpga/altera-pr-ip-core.c
> > +++ b/drivers/fpga/altera-pr-ip-core.c
> > @@ -108,7 +108,7 @@ static int alt_pr_fpga_write(struct fpga_manager *mgr, const char *buf,
> >   	u32 *buffer_32 = (u32 *)buf;
> >   	size_t i = 0;
> > -	if (count <= 0)
> > +	if (count == 0)
> >   		return -EINVAL;
> 
> Reviewed-by: Tom Rix <trix@...hat.com>

Acked-by: Xu Yilun <yilun.xu@...el.com>

> 
> >   	/* Write out the complete 32-bit chunks */