[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <c8c2b89b-8546-8449-a27e-ef6e89186e26@infradead.org>
Date: Wed, 6 Apr 2022 20:16:30 -0700
From: Randy Dunlap <rdunlap@...radead.org>
To: linux-kernel@...r.kernel.org
Cc: kernel test robot <lkp@...el.com>,
Kees Cook <keescook@...omium.org>,
Arnd Bergmann <arnd@...db.de>,
Michael Ellerman <mpe@...erman.id.au>,
Finn Thain <fthain@...ux-m68k.org>,
Geert Uytterhoeven <geert@...ux-m68k.org>,
Nathan Chancellor <nathan@...nel.org>,
Nick Desaulniers <ndesaulniers@...gle.com>,
Benjamin Herrenschmidt <benh@...nel.crashing.org>,
linuxppc-dev@...ts.ozlabs.org
Subject: Re: [PATCH] macintosh: fix via-pmu and via-cuda build errors
On 4/6/22 19:37, Randy Dunlap wrote:
> When CONFIG_INPUT=m, the input_*() family of functions is not
> available to builtin drivers.
>
> When CONFIG_RTC_CLASS is not set, rtc_tm_to_time64() is not defined.
>
> Fix multiple build errors by making these Kconfig symbols required by
> ADB_CUDA (RTC_CLASS) and ADB_PMU (RTC_CLASS and INPUT).
Ah yes, Finn has already fixed the INPUT problems here.
Maybe that patch hasn't been merged anywhere yet?
The RTC_CLASS problem is still present AFAICT.
> m68k-linux-ld: drivers/macintosh/via-pmu.o: in function `pmu_set_rtc_time':
> drivers/macintosh/via-pmu.c:1758: undefined reference to `rtc_tm_to_time64'
> m68k-linux-ld: drivers/macintosh/via-pmu-event.o: in function `input_report_key':
> include/linux/input.h:425: undefined reference to `input_event'
> m68k-linux-ld: drivers/macintosh/via-pmu-event.o: in function `input_report_switch':
> include/linux/input.h:445: undefined reference to `input_event'
> m68k-linux-ld: drivers/macintosh/via-pmu-event.o: in function `via_pmu_event_init':
> drivers/macintosh/via-pmu-event.c:38: undefined reference to `input_allocate_device'
> m68k-linux-ld: drivers/macintosh/via-pmu-event.c:53: undefined reference to `input_register_device'
> m68k-linux-ld: drivers/macintosh/via-pmu-event.c:55: undefined reference to `input_free_device'
> m68k-linux-ld: drivers/macintosh/via-cuda.o: in function `cuda_set_rtc_time':
> drivers/macintosh/via-cuda.c:797: undefined reference to `rtc_tm_to_time64'
>
> Fixes: 0792a2c8e0bb ("macintosh: Use common code to access RTC")
> Signed-off-by: Randy Dunlap <rdunlap@...radead.org>
> Reported-by: kernel test robot <lkp@...el.com>
> Cc: Kees Cook <keescook@...omium.org>
> Cc: Arnd Bergmann <arnd@...db.de>
> Cc: Michael Ellerman <mpe@...erman.id.au>
> Cc: Finn Thain <fthain@...ux-m68k.org>
> Cc: Geert Uytterhoeven <geert@...ux-m68k.org>
> Cc: Nathan Chancellor <nathan@...nel.org>
> Cc: Nick Desaulniers <ndesaulniers@...gle.com>
> Cc: Benjamin Herrenschmidt <benh@...nel.crashing.org>
> Cc: linuxppc-dev@...ts.ozlabs.org
> ---
> This is a big hammer type of patch. We could possibly do (a) some
> conditional code blocks for RTC_CLASS and (b) only build via-pmu-event
> if CONFIG_INPUT=y if needed.
>
> drivers/macintosh/Kconfig | 3 +++
> 1 file changed, 3 insertions(+)
>
> --- a/drivers/macintosh/Kconfig
> +++ b/drivers/macintosh/Kconfig
> @@ -44,6 +44,7 @@ config ADB_IOP
> config ADB_CUDA
> bool "Support for Cuda/Egret based Macs and PowerMacs"
> depends on (ADB || PPC_PMAC) && !PPC_PMAC64
> + depends on RTC_CLASS
> help
> This provides support for Cuda/Egret based Macintosh and
> Power Macintosh systems. This includes most m68k based Macs,
> @@ -57,6 +58,8 @@ config ADB_CUDA
> config ADB_PMU
> bool "Support for PMU based PowerMacs and PowerBooks"
> depends on PPC_PMAC || MAC
> + depends on INPUT=y
> + depends on RTC_CLASS
> help
> On PowerBooks, iBooks, and recent iMacs and Power Macintoshes, the
> PMU is an embedded microprocessor whose primary function is to
--
~Randy
Powered by blists - more mailing lists