linux-kernel - Re: [PATCH] testing/selftests/mqueue: Fix mq_perf

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <F30C53D1-F01A-44C2-A2FB-E024FF2CAEC8@linux.vnet.ibm.com>
Date:   Thu, 7 Apr 2022 10:00:35 +0530
From:   Athira Rajeev <atrajeev@...ux.vnet.ibm.com>
To:     Shuah Khan <skhan@...uxfoundation.org>
Cc:     shuah@...nel.org, linux-kselftest@...r.kernel.org,
        disgoel@...ux.vnet.ibm.com,
        Arnaldo Carvalho de Melo <acme@...nel.org>,
        Jiri Olsa <jolsa@...nel.org>,
        Michael Ellerman <mpe@...erman.id.au>,
        linux-perf-users@...r.kernel.org, linuxppc-dev@...ts.ozlabs.org,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        maddy@...ux.vnet.ibm.com, kajoljain <kjain@...ux.ibm.com>,
        srikar@...ux.vnet.ibm.com
Subject: Re: [PATCH] testing/selftests/mqueue: Fix mq_perf_tests to free the
 allocated cpu set



> On 07-Apr-2022, at 1:35 AM, Shuah Khan <skhan@...uxfoundation.org> wrote:
> 
> On 4/6/22 11:57 AM, Athira Rajeev wrote:
>> The selftest "mqueue/mq_perf_tests.c" use CPU_ALLOC to allocate
>> CPU set. This cpu set is used further in pthread_attr_setaffinity_np
>> and by pthread_create in the code. But in current code, allocated
>> cpu set is not freed. Fix this by adding CPU_FREE after its usage
>> is done.
> 
> Good find.
> 
>> Signed-off-by: Athira Rajeev <atrajeev@...ux.vnet.ibm.com>
>> ---
>>  tools/testing/selftests/mqueue/mq_perf_tests.c | 1 +
>>  1 file changed, 1 insertion(+)
>> diff --git a/tools/testing/selftests/mqueue/mq_perf_tests.c b/tools/testing/selftests/mqueue/mq_perf_tests.c
>> index b019e0b8221c..17c41f216bef 100644
>> --- a/tools/testing/selftests/mqueue/mq_perf_tests.c
>> +++ b/tools/testing/selftests/mqueue/mq_perf_tests.c
>> @@ -732,6 +732,7 @@ int main(int argc, char *argv[])
>>  		pthread_attr_destroy(&thread_attr);
>>  	}
>>  +	CPU_FREE(cpu_set);
>>  	if (!continuous_mode) {
>>  		pthread_join(cpu_threads[0], &retval);
>>  		shutdown((long)retval, "perf_test_thread()", __LINE__);
> 
> CPU_ALLOC() is called very early on in main() and there are a
> few error paths that exit without calling CPU_FREE. This change
> doesn't fully fix the problem.
> 
> Review the other exit paths where CPU_FREE is needed.
Sure, Thanks for the review.
I will check and post a V2

thanks
Athira
> 
> thanks,
> -- Shuah