linux-kernel - Re: [PATCH 3/3] drbd: set QUEUE_FLAG_STABLE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Yk6Bc7lvjCsmlkoq@infradead.org>
Date:   Wed, 6 Apr 2022 23:15:15 -0700
From:   Christoph Hellwig <hch@...radead.org>
To:     Christoph Böhmwalder 
        <christoph.boehmwalder@...bit.com>
Cc:     Jens Axboe <axboe@...nel.dk>, drbd-dev@...ts.linbit.com,
        linux-kernel@...r.kernel.org,
        Lars Ellenberg <lars.ellenberg@...bit.com>,
        Philipp Reisner <philipp.reisner@...bit.com>,
        linux-block@...r.kernel.org,
        Christoph Böhmwalder 
        <christoph@...hmwalder.at>
Subject: Re: [PATCH 3/3] drbd: set QUEUE_FLAG_STABLE_WRITES

On Wed, Apr 06, 2022 at 09:04:45PM +0200, Christoph Böhmwalder wrote:
> From: Christoph Böhmwalder <christoph@...hmwalder.at>
> 
> We want our pages not to change while they are being written.

Please document the _why_.  A commit like that will leave everyone
looking at this code in the future rather puzzled.