linux-kernel - Re: [RESEND PATCH] arm: dts: at91: Fix boolean properties with values

Open Source and information security mailing list archives

Date:   Thu, 7 Apr 2022 06:36:08 +0000
From:   <Claudiu.Beznea@...rochip.com>
To:     <robh@...nel.org>, <krzysztof.kozlowski@...onical.com>,
        <Nicolas.Ferre@...rochip.com>, <alexandre.belloni@...tlin.com>,
        <Ludovic.Desroches@...rochip.com>, <soc@...nel.org>
CC:     <devicetree@...r.kernel.org>,
        <linux-arm-kernel@...ts.infradead.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [RESEND PATCH] arm: dts: at91: Fix boolean properties with values

On 06.04.2022 22:09, Rob Herring wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> 
> Boolean properties in DT are present or not present and don't take a value.
> A property such as 'foo = <0>;' evaluated to true. IOW, the value doesn't
> matter.
> 
> It may have been intended that 0 values are false, but there is no change
> in behavior with this patch.
> 
> Signed-off-by: Rob Herring <robh@...nel.org>

Reviewed-by: Claudiu Beznea <claudiu.beznea@...rochip.com>


> ---
> Can someone apply this for 5.18 please.
> 
>  arch/arm/boot/dts/at91-kizbox3-hs.dts      | 2 +-
>  arch/arm/boot/dts/at91-kizbox3_common.dtsi | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/at91-kizbox3-hs.dts b/arch/arm/boot/dts/at91-kizbox3-hs.dts
> index 2799b2a1f4d2..f7d90cf1bb77 100644
> --- a/arch/arm/boot/dts/at91-kizbox3-hs.dts
> +++ b/arch/arm/boot/dts/at91-kizbox3-hs.dts
> @@ -225,7 +225,7 @@ pinctrl_pio_zbe_rst: gpio_zbe_rst {
>                 pinctrl_pio_io_reset: gpio_io_reset {
>                         pinmux = <PIN_PB30__GPIO>;
>                         bias-disable;
> -                       drive-open-drain = <1>;
> +                       drive-open-drain;
>                         output-low;
>                 };
>                 pinctrl_pio_input: gpio_input {
> diff --git a/arch/arm/boot/dts/at91-kizbox3_common.dtsi b/arch/arm/boot/dts/at91-kizbox3_common.dtsi
> index abe27adfa4d6..465664628419 100644
> --- a/arch/arm/boot/dts/at91-kizbox3_common.dtsi
> +++ b/arch/arm/boot/dts/at91-kizbox3_common.dtsi
> @@ -211,7 +211,7 @@ pinctrl_flx4_default: flx4_i2c6_default {
>                 pinmux = <PIN_PD12__FLEXCOM4_IO0>, //DATA
>                 <PIN_PD13__FLEXCOM4_IO1>; //CLK
>                 bias-disable;
> -               drive-open-drain = <1>;
> +               drive-open-drain;
>         };
> 
>         pinctrl_pwm0 {
> --
> 2.32.0
> 
> 
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@...ts.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives