linux-kernel - Re: [PATCH 1/2] mmc: renesas_sdhi: Jump to error path instead of returning directly

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Yk6PD/aHJMfTlcjv@ninjato>
Date:   Thu, 7 Apr 2022 09:13:19 +0200
From:   Wolfram Sang <wsa+renesas@...g-engineering.com>
To:     Biju Das <biju.das.jz@...renesas.com>
Cc:     "Lad, Prabhakar" <prabhakar.csengg@...il.com>,
        Prabhakar Mahadev Lad <prabhakar.mahadev-lad.rj@...renesas.com>,
        Ulf Hansson <ulf.hansson@...aro.org>,
        Philipp Zabel <p.zabel@...gutronix.de>,
        Yoshihiro Shimoda <yoshihiro.shimoda.uh@...esas.com>,
        "linux-mmc@...r.kernel.org" <linux-mmc@...r.kernel.org>,
        Pavel Machek <pavel@...x.de>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-renesas-soc@...r.kernel.org" 
        <linux-renesas-soc@...r.kernel.org>
Subject: Re: [PATCH 1/2] mmc: renesas_sdhi: Jump to error path instead of
 returning directly


> I guess it has to move up, first get reset handle and clock handle and return error
> directly in case of error, Then do clk/reset ops. 
> 
> > 
> > Wolfram, what is your preference on the above?

Yes, moving up makes sense. First check all the handles before we
actually initialize the hardware.

Thanks for pointing all this out.


Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)