linux-kernel - Re: [PATCH 2/2] remoteproc: imx_dsp_rproc: use common rproc_elf_load

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAEnQRZDpsMQUTSBvhztsnApEkWqtnjxf-NbNbr+L22mmiAV8AA@mail.gmail.com>
Date:   Thu, 7 Apr 2022 11:05:14 +0300
From:   Daniel Baluta <daniel.baluta@...il.com>
To:     Peng Fan <peng.fan@....com>
Cc:     "Peng Fan (OSS)" <peng.fan@....nxp.com>,
        "bjorn.andersson@...aro.org" <bjorn.andersson@...aro.org>,
        Mathieu Poirier <mathieu.poirier@...aro.org>,
        Shawn Guo <shawnguo@...nel.org>,
        Sascha Hauer <s.hauer@...gutronix.de>,
        "S.J. Wang" <shengjiu.wang@....com>,
        "linux-remoteproc@...r.kernel.org" <linux-remoteproc@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Pengutronix Kernel Team <kernel@...gutronix.de>,
        Fabio Estevam <festevam@...il.com>,
        dl-linux-imx <linux-imx@....com>,
        linux-arm-kernel <linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH 2/2] remoteproc: imx_dsp_rproc: use common rproc_elf_load_segments

On Wed, Apr 6, 2022 at 2:25 PM Daniel Baluta <daniel.baluta@...il.com> wrote:
>
> On Wed, Apr 6, 2022 at 1:58 PM Peng Fan <peng.fan@....com> wrote:
> >
> > > Subject: Re: [PATCH 2/2] remoteproc: imx_dsp_rproc: use common
> > > rproc_elf_load_segments
> > >
> > > On Thu, Mar 24, 2022 at 1:34 AM Peng Fan (OSS) <peng.fan@....nxp.com>
> > > wrote:
> > > >
> > > > From: Peng Fan <peng.fan@....com>
> > > >
> > > > remoteproc elf loader supports the specific case that segments have
> > > > PT_LOAD and memsz/filesz set to zero, so no duplicate code.
> > > >
> > > > Signed-off-by: Peng Fan <peng.fan@....com>

Acked-by: Daniel Baluta <daniel.baluta@....com>

Peng,

I'm fine going on with this now. Next we need to replace the boolean is_iomem
with a flags parameter to hold ATT_IOMEM, ATT_IOMEM32, etc.

> > >
> > > I think this change OK, but we have a case with the DSP were reads/writes
> > > should be done in multiples of 32/64.
> > >
> > > We need a way to provide our own "memcpy" function to be used by
> > > rproc_elf_load_segments.
> >
> > I think when generating elf file, the sections needs to be 32/64bits aligned.
>
> Sure, that could be a fix. But some malicious user can crash the kernel
> by crafting an elf with unaligned sections.