linux-kernel - RE: [EXT] Re: [PATCH v1 3/5] drm: bridge: dw

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <DB7PR04MB54508F0ACD00B482201D7916F4E69@DB7PR04MB5450.eurprd04.prod.outlook.com>
Date:   Thu, 7 Apr 2022 08:31:31 +0000
From:   Sandor Yu <sandor.yu@....com>
To:     Neil Armstrong <narmstrong@...libre.com>,
        "dri-devel@...ts.freedesktop.org" <dri-devel@...ts.freedesktop.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "andrzej.hajda@...el.com" <andrzej.hajda@...el.com>,
        "robert.foss@...aro.org" <robert.foss@...aro.org>,
        "Laurent.pinchart@...asonboard.com" 
        <Laurent.pinchart@...asonboard.com>,
        "jonas@...boo.se" <jonas@...boo.se>,
        "jernej.skrabec@...il.com" <jernej.skrabec@...il.com>
CC:     "S.J. Wang" <shengjiu.wang@....com>,
        "cai.huoqing@...ux.dev" <cai.huoqing@...ux.dev>,
        "maxime@...no.tech" <maxime@...no.tech>,
        "harry.wentland@....com" <harry.wentland@....com>,
        "hverkuil-cisco@...all.nl" <hverkuil-cisco@...all.nl>,
        "amuel@...lland.org" <amuel@...lland.org>
Subject: RE: [EXT] Re: [PATCH v1 3/5] drm: bridge: dw_hdmi: Enable GCP only
 for Deep Color

Hi,

> -----Original Message-----
> From: Neil Armstrong <narmstrong@...libre.com>
> Sent: 2022年4月6日 17:20
> To: Sandor Yu <sandor.yu@....com>; dri-devel@...ts.freedesktop.org;
> linux-kernel@...r.kernel.org; andrzej.hajda@...el.com;
> robert.foss@...aro.org; Laurent.pinchart@...asonboard.com;
> jonas@...boo.se; jernej.skrabec@...il.com
> Cc: S.J. Wang <shengjiu.wang@....com>; cai.huoqing@...ux.dev;
> maxime@...no.tech; harry.wentland@....com; hverkuil-cisco@...all.nl;
> amuel@...lland.org
> Subject: [EXT] Re: [PATCH v1 3/5] drm: bridge: dw_hdmi: Enable GCP only for
> Deep Color
> 
> Caution: EXT Email
> 
> On 06/04/2022 10:48, Sandor.yu@....com wrote:
> > From: Sandor Yu <Sandor.yu@....com>
> >
> > HDMI1.4b specification section 6.5.3:
> > Source shall only send GCPs with non-zero CD to sinks that indicate
> > support for Deep Color.
> >
> > DW HDMI GPC default enabled, clear gpc_auto bit for bpp 24.
> >
> > Signed-off-by: Sandor Yu <Sandor.yu@....com>
> > ---
> >   drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 8 ++++++++
> >   1 file changed, 8 insertions(+)
> >
> > diff --git a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c
> > b/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c
> > index b11577de4836..c7b11582529e 100644
> > --- a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c
> > +++ b/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c
> > @@ -1160,6 +1160,14 @@ static void hdmi_video_packetize(struct
> dw_hdmi *hdmi)
> >               HDMI_VP_PR_CD_DESIRED_PR_FACTOR_MASK);
> >       hdmi_writeb(hdmi, val, HDMI_VP_PR_CD);
> >
> > +     val = hdmi_readb(hdmi, HDMI_FC_DATAUTO3);
> > +     if (color_depth == 4)
> > +             /* disable Auto GCP when bpp 24 */
> > +             val &= ~0x4;
> > +     else
> > +             val |= 0x4;
> > +     hdmi_writeb(hdmi, val, HDMI_FC_DATAUTO3);
> > +
> >       hdmi_modb(hdmi,
> HDMI_VP_STUFF_PR_STUFFING_STUFFING_MODE,
> >                 HDMI_VP_STUFF_PR_STUFFING_MASK,
> HDMI_VP_STUFF);
> >
> 
> Do you handle the case when color_depth == 0 when output is YUV422 ?
For YUV422 color depth 8, the gcp_auto bit need clear too, I will add it.
> 
> Neil
Thanks,
Sandor