lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 7 Apr 2022 11:09:14 +0200 From: Javier Martinez Canillas <javierm@...hat.com> To: linux-kernel@...r.kernel.org, dri-devel@...ts.freedesktop.org, Thomas Zimmermann <tzimmermann@...e.de>, Borislav Petkov <bp@...e.de>, Greg Kroah-Hartman <gregkh@...uxfoundation.org>, Miaoqian Lin <linmq006@...il.com> Subject: Re: [RESEND RFC PATCH 1/5] firmware: sysfb: Make sysfb_create_simplefb() return a pdev pointer Hello Daniel, On 4/7/22 11:03, Daniel Vetter wrote: > On Wed, Apr 06, 2022 at 11:39:15PM +0200, Javier Martinez Canillas wrote: >> This function just returned 0 on success or an errno code on error, but it >> could be useful to sysfb_init() to get a pointer to the device registered. >> >> Signed-off-by: Javier Martinez Canillas <javierm@...hat.com> > > You need to rebase this onto 202c08914ba5 ("firmware: sysfb: fix > platform-device leak in error path") which fixes the same error path leak > you are fixing in here too. Or we just have a neat conflict when merging > :-) But in that case please mention that you fix the error path leak too > so it's less confusing when Linus or someone needs to resolve the > conflict. > Ups, I thought that had my local tree up-to-date but it seems that was a few days old. I've updated my remote now and rebased, so will have this fixed in the next revision of the series. And this patch becomes smaller indeed :) > Anyway Reviewed-by: Daniel Vetter <daniel.vetter@...ll.ch> > Thanks! -- Best regards, Javier Martinez Canillas Linux Engineering Red Hat
Powered by blists - more mailing lists