linux-kernel - Re: [PATCH] dt-bindings: i2c: convert i2c-mt65xx to json-schema

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <507fd6e4-a425-dbbe-f76f-da90870ff29e@collabora.com>
Date:   Thu, 7 Apr 2022 11:45:30 +0200
From:   AngeloGioacchino Del Regno 
        <angelogioacchino.delregno@...labora.com>
To:     Miles Chen <miles.chen@...iatek.com>
Cc:     devicetree@...r.kernel.org, hsinyi@...omium.org,
        kewei.xu@...iatek.com, krzk+dt@...nel.org,
        linux-arm-kernel@...ts.infradead.org, linux-i2c@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-mediatek@...ts.infradead.org,
        matthias.bgg@...il.com, qii.wang@...iatek.com, robh+dt@...nel.org,
        wsa@...nel.org
Subject: Re: [PATCH] dt-bindings: i2c: convert i2c-mt65xx to json-schema

Il 07/04/22 01:24, Miles Chen ha scritto:
> Hi AngeloGioacchino,
> 
>> Convert I2C binding for MediaTek SoCs to Devicetree schema.
>>
>> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>
>> ---
>>   .../devicetree/bindings/i2c/i2c-mt65xx.txt    |  53 --------
>>   .../devicetree/bindings/i2c/i2c-mt65xx.yaml   | 118 ++++++++++++++++++
>>   MAINTAINERS                                   |   2 +-
>>   3 files changed, 119 insertions(+), 54 deletions(-)
>>   delete mode 100644 Documentation/devicetree/bindings/i2c/i2c-mt65xx.txt
>>   create mode 100644 Documentation/devicetree/bindings/i2c/i2c-mt65xx.yaml
>>
>> diff --git a/Documentation/devicetree/bindings/i2c/i2c-mt65xx.txt b/Documentation/devicetree/bindings/i2c/i2c-mt65xx.txt
>> deleted file mode 100644
>> index 026985b8f61a..000000000000
>> --- a/Documentation/devicetree/bindings/i2c/i2c-mt65xx.txt
>> +++ /dev/null

..snip..

>> -  - clocks: clock name from clock manager
>> -  - clock-names: Must include "main" and "dma", "arb" is for multi-master that
>> -    one bus has more than two i2c controllers, if enable have-pmic need include
>> -    "pmic" extra.
> 
>> +
>> +  clocks:
>> +    minItems: 1
>> +    items:
>> +      - description: Main clock for I2C bus
>> +      - description: Clock for I2C via DMA
>> +      - description: Bus arbitrator clock
>> +      - description: Clock for I2C from PMIC
>> +
>> +  clock-names:
>> +    minItems: 1
>> +    items:
>> +      - const: main
>> +      - const: dma
>> +      - const: arb
>> +      - const: pmic
> 
> I read "clock-names: Must include "main" and "dma"" from i2c-mt65xx.txt.
> Does it means that we should have at least 2 clock-names (minItems: 2)?
> 
> Thanks,
> Miles
> 

Hello Miles,
yes, you're right, I just rechecked the code and this is indeed the case.

Thanks for catching that, will send a v2 shortly.

Regards,
Angelo