linux-kernel - Re: [PATCH] clk: meson: meson8b: fix a memory leak in meson8b_clkc_init

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <bf62ecb64b6c2667ee22d0ecbf11c53802caa7a1.camel@pengutronix.de>
Date:   Thu, 07 Apr 2022 12:05:26 +0200
From:   Philipp Zabel <p.zabel@...gutronix.de>
To:     xkernel.wang@...mail.com, narmstrong@...libre.com,
        jbrunet@...libre.com, mturquette@...libre.com, sboyd@...nel.org,
        khilman@...libre.com
Cc:     martin.blumenstingl@...glemail.com,
        linux-amlogic@...ts.infradead.org, linux-clk@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] clk: meson: meson8b: fix a memory leak in
 meson8b_clkc_init_common()

On Do, 2022-04-07 at 17:28 +0800, xkernel.wang@...mail.com wrote:
> From: Xiaoke Wang <xkernel.wang@...mail.com>
> 
> `rstc` is allocated by kzalloc() for resetting the controller register,
> however, if reset_controller_register() fails, `rstc` is not properly
> released before returning, which can lead to memory leak.
> Therefore, this patch adds kfree(rstc) on the above error path.
> 
> Signed-off-by: Xiaoke Wang <xkernel.wang@...mail.com>

Reviewed-by: Philipp Zabel <p.zabel@...gutronix.de>

regards
Philipp