lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Date:   Thu, 7 Apr 2022 18:36:04 +0800
From:   Haowen Bai <baihaowen@...zu.com>
To:     "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>
CC:     Haowen Bai <baihaowen@...zu.com>, <netdev@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>
Subject: [PATCH V2] ethernet: Fix some formatting issues

reported by checkpatch.pl

WARNING: suspect code indent for conditional statements (16, 16)
#732: FILE: drivers/net/ethernet/3com/3c589_cs.c:732:
CHECK: Alignment should match open parenthesis
#733: FILE: drivers/net/ethernet/3com/3c589_cs.c:733:
CHECK: Alignment should match open parenthesis
#735: FILE: drivers/net/ethernet/3com/3c589_cs.c:735:
WARNING: suspect code indent for conditional statements (16, 16)
#736: FILE: drivers/net/ethernet/3com/3c589_cs.c:736:
CHECK: Alignment should match open parenthesis
#737: FILE: drivers/net/ethernet/3com/3c589_cs.c:737:
CHECK: Alignment should match open parenthesis
#739: FILE: drivers/net/ethernet/3com/3c589_cs.c:739:
Signed-off-by: Haowen Bai <baihaowen@...zu.com>
---
V1->V2: add detail of description

 drivers/net/ethernet/3com/3c589_cs.c | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/drivers/net/ethernet/3com/3c589_cs.c b/drivers/net/ethernet/3com/3c589_cs.c
index 4673bc1604e7..c46353375909 100644
--- a/drivers/net/ethernet/3com/3c589_cs.c
+++ b/drivers/net/ethernet/3com/3c589_cs.c
@@ -730,13 +730,13 @@ static void media_check(struct timer_list *t)
 
 	if (media != lp->media_status) {
 		if ((media & lp->media_status & 0x8000) &&
-				((lp->media_status ^ media) & 0x0800))
-		netdev_info(dev, "%s link beat\n",
-				(lp->media_status & 0x0800 ? "lost" : "found"));
+		    ((lp->media_status ^ media) & 0x0800))
+			netdev_info(dev, "%s link beat\n",
+				    (lp->media_status & 0x0800 ? "lost" : "found"));
 		else if ((media & lp->media_status & 0x4000) &&
-		 ((lp->media_status ^ media) & 0x0010))
-		netdev_info(dev, "coax cable %s\n",
-				(lp->media_status & 0x0010 ? "ok" : "problem"));
+			 ((lp->media_status ^ media) & 0x0010))
+			netdev_info(dev, "coax cable %s\n",
+				    (lp->media_status & 0x0010 ? "ok" : "problem"));
 		if (dev->if_port == 0) {
 			if (media & 0x8000) {
 				if (media & 0x0800)
-- 
2.7.4

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ