linux-kernel - Re: [PATCH] Btrfs: remove redundant judgment

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20220407104748.GD15609@twin.jikos.cz>
Date:   Thu, 7 Apr 2022 12:47:48 +0200
From:   David Sterba <dsterba@...e.cz>
To:     cgel.zte@...il.com
Cc:     dsterba@...e.cz, clm@...com, dsterba@...e.com,
        josef@...icpanda.com, linux-btrfs@...r.kernel.org,
        linux-kernel@...r.kernel.org, lv.ruyi@....com.cn
Subject: Re: [PATCH] Btrfs: remove redundant judgment

On Thu, Apr 07, 2022 at 01:57:00AM +0000, cgel.zte@...il.com wrote:
> < Ok, we can drop the check, have you looked if there are more similar
> < places to update?
> I found six by coccinelle, but they are in different paths.Should I
> send one patch or six?

As this is a simple change it can be in one patch, provided that it's
the same logic (dropping inode check before iput).

I've found only 2 instances with this coccinelle script:

@@
expression E;
@@

* if (E)
*       iput(E);
--

not sure where you found 6.