linux-kernel - Re: [PATCH v2] staging: media: ipu3: Fix AWB x_start position when rightmost stripe is used

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220407115133.GL3293@kadam>
Date:   Thu, 7 Apr 2022 14:51:33 +0300
From:   Dan Carpenter <dan.carpenter@...cle.com>
To:     Kate Hsuan <hpa@...hat.com>
Cc:     Sakari Ailus <sakari.ailus@...ux.intel.com>,
        Bingbu Cao <bingbu.cao@...el.com>,
        Tianshu Qiu <tian.shu.qiu@...el.com>,
        Mauro Carvalho Chehab <mchehab@...nel.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Jean-Michel Hautbois <jeanmichel.hautbois@...asonboard.com>,
        linux-media@...r.kernel.org, linux-staging@...ts.linux.dev,
        linux-kernel@...r.kernel.org, hdegoede@...hat.com
Subject: Re: [PATCH v2] staging: media: ipu3: Fix AWB x_start position when
 rightmost stripe is used

On Thu, Apr 07, 2022 at 06:57:24PM +0800, Kate Hsuan wrote:
> A not calibrated x_start setting would result in an incorrect AWB location
> configuration on a sensor when only the rightmost stripe is used. x_start
> should be calibrated by subtracting the stripe offset to set the coordinate
> to the correct position on the second stripe.
> 

I wish the commit description said more about what the bug looks like to
the user.  This is the front facing camera, right?  Is part of the video
blank or what's the deal?

> Signed-off-by: Kate Hsuan <hpa@...hat.com>
> ---
> Correct the patch. The correction should be awb, not awb_fr.

I tried to review the original patch and it was impossible.  I saw
you're from an @redhat.com email address so I decided it must be right.

I kind of get that you need to be a domain expert to review these
patches but this function is such a mess...

regards,
dan carpenter