linux-kernel - Re: [PATCH] staging: rtl8712: fix camel case in function r8712_generate

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 7 Apr 2022 14:14:29 +0200 (CEST)
From:   Julia Lawall <julia.lawall@...ia.fr>
To:     Mahak Gupta <mahak_g@...iitr.ac.in>
cc:     Larry.Finger@...inger.net, florian.c.schilhabel@...glemail.com,
        gregkh@...uxfoundation.org, linux-staging@...ts.linux.dev,
        linux-kernel@...r.kernel.org, outreachy@...ts.linux.dev
Subject: Re: [PATCH] staging: rtl8712: fix camel case in function
 r8712_generate_ie



On Thu, 7 Apr 2022, Mahak Gupta wrote:

> Adhere to linux kernel coding style.
>
> Reported by checkpatch:
>
> CHECK: Avoid CamelCase: <beaconPeriod>

As another patch, you could also adjust the structure field name.

julia

>
> Signed-off-by: Mahak Gupta <mahak_g@...iitr.ac.in>
> ---
>  drivers/staging/rtl8712/ieee80211.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/rtl8712/ieee80211.c b/drivers/staging/rtl8712/ieee80211.c
> index f926809b1021..7d8f1a29d18a 100644
> --- a/drivers/staging/rtl8712/ieee80211.c
> +++ b/drivers/staging/rtl8712/ieee80211.c
> @@ -162,13 +162,13 @@ int r8712_generate_ie(struct registry_priv *registrypriv)
>  	uint sz = 0;
>  	struct wlan_bssid_ex *dev_network = &registrypriv->dev_network;
>  	u8 *ie = dev_network->IEs;
> -	u16 beaconPeriod = (u16)dev_network->Configuration.BeaconPeriod;
> +	u16 beacon_period = (u16)dev_network->Configuration.BeaconPeriod;
>
>  	/*timestamp will be inserted by hardware*/
>  	sz += 8;
>  	ie += sz;
>  	/*beacon interval : 2bytes*/
> -	*(__le16 *)ie = cpu_to_le16(beaconPeriod);
> +	*(__le16 *)ie = cpu_to_le16(beacon_period);
>  	sz += 2;
>  	ie += 2;
>  	/*capability info*/
> --
> 2.17.1
>
>
>