linux-kernel - drivers/firmware/efi/capsule-loader.c:84:12: warning: no previous declaration for 'efi_capsule_setup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:   Sat, 9 Apr 2022 01:56:11 +0800
From:   kernel test robot <lkp@...el.com>
To:     Ard Biesheuvel <ard.biesheuvel@...aro.org>
Cc:     kbuild-all@...ts.01.org, linux-kernel@...r.kernel.org,
        Ingo Molnar <mingo@...nel.org>
Subject: drivers/firmware/efi/capsule-loader.c:84:12: warning: no previous
 declaration for 'efi_capsule_setup_info'

Hi Ard,

FYI, the error/warning still remains.

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   1831fed559732b132aef0ea8261ac77e73f7eadf
commit: 3fabd628d5ea24b02ddb1230ffca1df0f779f84e efi/capsule-loader: Redirect calls to efi_capsule_setup_info() via weak alias
date:   4 years, 10 months ago
config: i386-randconfig-a005 (https://download.01.org/0day-ci/archive/20220409/202204090125.wgI0L7F3-lkp@intel.com/config)
compiler: gcc-7 (Ubuntu 7.5.0-6ubuntu2) 7.5.0
reproduce (this is a W=1 build):
        # https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=3fabd628d5ea24b02ddb1230ffca1df0f779f84e
        git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
        git fetch --no-tags linus master
        git checkout 3fabd628d5ea24b02ddb1230ffca1df0f779f84e
        # save the config file to linux build tree
        mkdir build_dir
        make W=1 O=build_dir ARCH=i386 SHELL=/bin/bash arch/x86/platform/efi/ drivers/firmware/efi/ drivers/net/dsa/ fs/f2fs/ fs/xfs/ net/sunrpc/xprtrdma/

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>

All warnings (new ones prefixed by >>):

>> drivers/firmware/efi/capsule-loader.c:84:12: warning: no previous declaration for 'efi_capsule_setup_info' [-Wmissing-declarations]
    int __weak efi_capsule_setup_info(struct capsule_info *cap_info, void *kbuff,
               ^~~~~~~~~~~~~~~~~~~~~~


vim +/efi_capsule_setup_info +84 drivers/firmware/efi/capsule-loader.c

    72	
    73	/**
    74	 * efi_capsule_setup_info - obtain the efi capsule header in the binary and
    75	 *			    setup capsule_info structure
    76	 * @cap_info: pointer to current instance of capsule_info structure
    77	 * @kbuff: a mapped first page buffer pointer
    78	 * @hdr_bytes: the total received number of bytes for efi header
    79	 *
    80	 * Platforms with non-standard capsule update mechanisms can override
    81	 * this __weak function so they can perform any required capsule
    82	 * image munging. See quark_quirk_function() for an example.
    83	 **/
  > 84	int __weak efi_capsule_setup_info(struct capsule_info *cap_info, void *kbuff,
    85					  size_t hdr_bytes)
    86	{
    87		/* Only process data block that is larger than efi header size */
    88		if (hdr_bytes < sizeof(efi_capsule_header_t))
    89			return 0;
    90	
    91		memcpy(&cap_info->header, kbuff, sizeof(cap_info->header));
    92		cap_info->total_size = cap_info->header.imagesize;
    93	
    94		return __efi_capsule_setup_info(cap_info);
    95	}
    96	

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp