linux-kernel - Re: [PATCH] btrfs: restore inode creation before xattr setting

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20220408183733.GA15609@twin.jikos.cz>
Date:   Fri, 8 Apr 2022 20:37:33 +0200
From:   David Sterba <dsterba@...e.cz>
To:     Sweet Tea Dorminy <sweettea-kernel@...miny.me>
Cc:     Chris Mason <clm@...com>, Josef Bacik <josef@...icpanda.com>,
        David Sterba <dsterba@...e.com>, linux-kernel@...r.kernel.org,
        linux-btrfs@...r.kernel.org, kernel-team@...com,
        Omar Sandoval <osandov@...ndov.com>,
        Naohiro Aota <naohiro.aota@....com>
Subject: Re: [PATCH] btrfs: restore inode creation before xattr setting

On Fri, Apr 08, 2022 at 01:15:07PM -0400, Sweet Tea Dorminy wrote:
> According to the tree checker, "all xattrs with a given objectid follow
> the inode with that objectid in the tree" is an invariant. This was
> broken by the recent change "btrfs: move common inode creation code into
> btrfs_create_new_inode()", which moved acl creation and property
> inheritance (stored in xattrs) to before inode insertion into the tree.
> As a result, under certain timings, the xattrs could be written to the
> tree before the inode, causing the tree checker to report violation of
> the invariant.
> 
> Move property inheritance and acl creation back to their old ordering
> after the inode insertion.
> 
> Suggested-by: Omar Sandoval <osandov@...ndov.com>
> Reported-by: Naohiro Aota <naohiro.aota@....com>
> Signed-off-by: Sweet Tea Dorminy <sweettea-kernel@...miny.me>
> ---
> This should apply on top of osandov's patch at
>  https://lore.kernel.org/linux-btrfs/da6cfa1b8e42db5c8954680cac1ca322d463b880.1647306546.git.osandov@fb.com/
> 
> It's survived a good dose of fstests, and several iterations of specific
> tests that were failing, e.g. generic/650.

Thanks.

> David: I don't know if you'd rather roll this into osandov's original
> patch, or whether you'd like me or osandov to resend the patch linked
> above with this addition rolled into it, or whether you'd like to apply
> it separately.

For simple fixups sent as replies I can apply it manually but sometimes
it's better for me to do the review instead of trying to figure out what
was the real intention.

So patch applied cleanly and now pushed to misc-next, thanks.