linux-kernel - Re: [PATCH] btrfs: zstd: use spin

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 8 Apr 2022 20:44:49 +0200
From:   David Sterba <dsterba@...e.cz>
To:     Schspa Shi <schspa@...il.com>
Cc:     clm@...com, josef@...icpanda.com, dsterba@...e.com,
        terrelln@...com, linux-btrfs@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] btrfs: zstd: use spin_lock in timer function

On Sat, Apr 09, 2022 at 02:15:23AM +0800, Schspa Shi wrote:
> timer callback was running on bh, and there is no need to disable bh again.

Why do you think so? There was a specific fix fee13fe96529 ("btrfs:
correct zstd workspace manager lock to use spin_lock_bh()") that
actually added the _bh, so either you need to explain why exactly it's
not needed anymore and verify that the reported lockdep warning from the
fix does not happen.