linux-kernel - [peterz-queue:sched/wip.freezer 3/5] drivers/acpi/x86/s2idle.c:546:9: error: too few arguments to function 'unlock_system

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:   Fri, 8 Apr 2022 08:30:31 +0800
From:   kernel test robot <lkp@...el.com>
To:     Peter Zijlstra <peterz@...radead.org>
Cc:     kbuild-all@...ts.01.org, linux-kernel@...r.kernel.org
Subject: [peterz-queue:sched/wip.freezer 3/5]
 drivers/acpi/x86/s2idle.c:546:9: error: too few arguments to function
 'unlock_system_sleep'

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/peterz/queue.git sched/wip.freezer
head:   ed5b8f90d21512ee2392f35dbb0ab867c66d243d
commit: 46038225e7df3d71cc3fc0d3df5bb79e7cf136ec [3/5] freezer: Have {,un}lock_system_sleep() save/restore flags
config: x86_64-defconfig (https://download.01.org/0day-ci/archive/20220408/202204080853.ZTlryCwN-lkp@intel.com/config)
compiler: gcc-11 (Debian 11.2.0-19) 11.2.0
reproduce (this is a W=1 build):
        # https://git.kernel.org/pub/scm/linux/kernel/git/peterz/queue.git/commit/?id=46038225e7df3d71cc3fc0d3df5bb79e7cf136ec
        git remote add peterz-queue https://git.kernel.org/pub/scm/linux/kernel/git/peterz/queue.git
        git fetch --no-tags peterz-queue sched/wip.freezer
        git checkout 46038225e7df3d71cc3fc0d3df5bb79e7cf136ec
        # save the config file to linux build tree
        mkdir build_dir
        make W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>

All errors (new ones prefixed by >>):

   drivers/acpi/x86/s2idle.c: In function 'acpi_register_lps0_dev':
>> drivers/acpi/x86/s2idle.c:546:9: error: too few arguments to function 'unlock_system_sleep'
     546 |         unlock_system_sleep();
         |         ^~~~~~~~~~~~~~~~~~~
   In file included from drivers/acpi/x86/s2idle.c:20:
   include/linux/suspend.h:514:13: note: declared here
     514 | extern void unlock_system_sleep(unsigned int);
         |             ^~~~~~~~~~~~~~~~~~~
   drivers/acpi/x86/s2idle.c: In function 'acpi_unregister_lps0_dev':
   drivers/acpi/x86/s2idle.c:559:9: error: too few arguments to function 'unlock_system_sleep'
     559 |         unlock_system_sleep();
         |         ^~~~~~~~~~~~~~~~~~~
   In file included from drivers/acpi/x86/s2idle.c:20:
   include/linux/suspend.h:514:13: note: declared here
     514 | extern void unlock_system_sleep(unsigned int);
         |             ^~~~~~~~~~~~~~~~~~~


vim +/unlock_system_sleep +546 drivers/acpi/x86/s2idle.c

fef98671194be0 Rafael J. Wysocki 2020-12-17  538  
20e1d6402a71db Mario Limonciello 2022-03-17  539  int acpi_register_lps0_dev(struct acpi_s2idle_dev_ops *arg)
20e1d6402a71db Mario Limonciello 2022-03-17  540  {
20e1d6402a71db Mario Limonciello 2022-03-17  541  	if (!lps0_device_handle || sleep_no_lps0)
20e1d6402a71db Mario Limonciello 2022-03-17  542  		return -ENODEV;
20e1d6402a71db Mario Limonciello 2022-03-17  543  
20e1d6402a71db Mario Limonciello 2022-03-17  544  	lock_system_sleep();
20e1d6402a71db Mario Limonciello 2022-03-17  545  	list_add(&arg->list_node, &lps0_s2idle_devops_head);
20e1d6402a71db Mario Limonciello 2022-03-17 @546  	unlock_system_sleep();
20e1d6402a71db Mario Limonciello 2022-03-17  547  
20e1d6402a71db Mario Limonciello 2022-03-17  548  	return 0;
20e1d6402a71db Mario Limonciello 2022-03-17  549  }
20e1d6402a71db Mario Limonciello 2022-03-17  550  EXPORT_SYMBOL_GPL(acpi_register_lps0_dev);
20e1d6402a71db Mario Limonciello 2022-03-17  551  

:::::: The code at line 546 was first introduced by commit
:::::: 20e1d6402a71dba7ad2b81f332a3c14c7d3b939b ACPI / x86: Add support for LPS0 callback handler

:::::: TO: Mario Limonciello <mario.limonciello@....com>
:::::: CC: Hans de Goede <hdegoede@...hat.com>

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp