linux-kernel - RE: [PATCH v4] ACPI: APEI: fix missing erst record id

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4208d2e15341432ba1137600b7e5b9ae@intel.com>
Date:   Fri, 8 Apr 2022 19:24:58 +0000
From:   "Luck, Tony" <tony.luck@...el.com>
To:     "liuxp11@...natelecom.cn" <liuxp11@...natelecom.cn>,
        "rafael@...nel.org" <rafael@...nel.org>,
        "dave.hansen@...ux.intel.com" <dave.hansen@...ux.intel.com>,
        "x86@...nel.org" <x86@...nel.org>, "hpa@...or.com" <hpa@...or.com>,
        "keescook@...omium.org" <keescook@...omium.org>,
        "anton@...msg.org" <anton@...msg.org>,
        "ccross@...roid.com" <ccross@...roid.com>,
        "Moore, Robert" <robert.moore@...el.com>,
        "lenb@...nel.org" <lenb@...nel.org>,
        "james.morse@....com" <james.morse@....com>,
        "bp@...en8.de" <bp@...en8.de>,
        "tglx@...utronix.de" <tglx@...utronix.de>,
        "mingo@...hat.com" <mingo@...hat.com>,
        "Huang, Ying" <ying.huang@...el.com>,
        "gong.chen@...ux.intel.com" <gong.chen@...ux.intel.com>
CC:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-acpi@...r.kernel.org" <linux-acpi@...r.kernel.org>
Subject: RE: [PATCH v4] ACPI: APEI: fix missing erst record id

I think it might be a cleaner solution if you first implement a new function:

/*
 * Like erst_read(), but look for a specific record type (by size and guid)
 * also retry -ENOENT returns by skipping to next record_id
 */
ssize_t erst_read_record(u64 *record_id, struct cper_record_header *record,
			size_t buflen, size_t recordlen, const guid_t *guid)
{
}

Step 2: Update apei_read_mce() and erst_reader() to use this function.

Step 3: Apply your erst_clear_cache() fix to the new function

-Tony