linux-kernel - [PATCH] KVM: VMX: More brown paper bags! NOM NOM NOM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <20220408202815.386932-1-seanjc@google.com>
Date:   Fri,  8 Apr 2022 20:28:15 +0000
From:   Sean Christopherson <seanjc@...gle.com>
To:     Paolo Bonzini <pbonzini@...hat.com>
Cc:     Sean Christopherson <seanjc@...gle.com>,
        Vitaly Kuznetsov <vkuznets@...hat.com>,
        Wanpeng Li <wanpengli@...cent.com>,
        Jim Mattson <jmattson@...gle.com>,
        Joerg Roedel <joro@...tes.org>, kvm@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: [PATCH] KVM: VMX: More brown paper bags! NOM NOM NOM

Add a missing declaration that got dropped between my inline patch[1] and
what actually got posted[2].

In file included from arch/x86/kvm/mmu/mmu.c:4279:
arch/x86/kvm/mmu/paging_tmpl.h: In function ‘ept_walk_addr_generic’:
arch/x86/kvm/mmu/paging_tmpl.h:496:50: error: ‘EPT_VIOLATION_RWX_SHIFT’ undeclared
 (first use in this function); did you mean ‘EPT_VIOLATION_RWX_MASK’?
  496 |                                                  EPT_VIOLATION_RWX_SHIFT;
      |                                                  ^~~~~~~~~~~~~~~~~~~~~~~
      |                                                  EPT_VIOLATION_RWX_MASK

[1] https://lore.kernel.org/all/Yj0NOQOYEAG+Dz7+@google.com
[2] https://lore.kernel.org/all/20220329030108.97341-3-darcy.sh@antgroup.com

Fixes: 68ca1f59584e ("KVM: x86/mmu: Derive EPT violation RWX bits from EPTE RWX bits")
Signed-off-by: Sean Christopherson <seanjc@...gle.com>
---

Please squash, thanks!

 arch/x86/include/asm/vmx.h | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/x86/include/asm/vmx.h b/arch/x86/include/asm/vmx.h
index 46bc7072f6a2..6c343c6a1855 100644
--- a/arch/x86/include/asm/vmx.h
+++ b/arch/x86/include/asm/vmx.h
@@ -543,6 +543,7 @@ enum vm_entry_failure_code {
 #define EPT_VIOLATION_ACC_READ_BIT	0
 #define EPT_VIOLATION_ACC_WRITE_BIT	1
 #define EPT_VIOLATION_ACC_INSTR_BIT	2
+#define EPT_VIOLATION_RWX_SHIFT		3
 #define EPT_VIOLATION_GVA_IS_VALID_BIT	7
 #define EPT_VIOLATION_GVA_TRANSLATED_BIT 8
 #define EPT_VIOLATION_ACC_READ		(1 << EPT_VIOLATION_ACC_READ_BIT)

base-commit: 59d9e75d641565603e7c293f4cec182d86db8586
-- 
2.35.1.1178.g4f1659d476-goog