linux-kernel - Re: [PATCH] drm/radeon: change cayman_default

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CADnq5_MSrNYWJE0krKTs4SkOqsNtrVyM0PyQanO-YQYV+jSV4g@mail.gmail.com>
Date:   Fri, 8 Apr 2022 16:48:26 -0400
From:   Alex Deucher <alexdeucher@...il.com>
To:     Tom Rix <trix@...hat.com>
Cc:     "Deucher, Alexander" <alexander.deucher@....com>,
        Christian Koenig <christian.koenig@....com>,
        xinhui pan <Xinhui.Pan@....com>,
        Dave Airlie <airlied@...ux.ie>,
        Daniel Vetter <daniel@...ll.ch>,
        Maling list - DRI developers 
        <dri-devel@...ts.freedesktop.org>,
        LKML <linux-kernel@...r.kernel.org>,
        amd-gfx list <amd-gfx@...ts.freedesktop.org>
Subject: Re: [PATCH] drm/radeon: change cayman_default_state table from global
 to static

On Thu, Apr 7, 2022 at 5:47 PM Tom Rix <trix@...hat.com> wrote:
>
> cayman_default_state and cayman_default_size are only
> used in ni.c.  Single file symbols should be static.
> So move their definitions to cayman_blit_shaders.h
> and change their storage-class-specifier to static.
>
> Remove unneeded cayman_blit_shader.c
>
> cayman_ps/vs definitions were removed with
> commit 4f8629675800 ("drm/radeon/kms: remove r6xx+ blit copy routines")
> So their declarations in cayman_blit_shader.h
> are not needed, so remove them.
>
> Signed-off-by: Tom Rix <trix@...hat.com>

Applied.  Thanks!

Alex