linux-kernel - Re: [RFC PATCH v5 024/104] KVM: TDX: create/destroy VM structure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220408005116.GB2864606@ls.amr.corp.intel.com>
Date:   Thu, 7 Apr 2022 17:51:16 -0700
From:   Isaku Yamahata <isaku.yamahata@...il.com>
To:     Paolo Bonzini <pbonzini@...hat.com>
Cc:     isaku.yamahata@...el.com, kvm@...r.kernel.org,
        linux-kernel@...r.kernel.org, isaku.yamahata@...il.com,
        Jim Mattson <jmattson@...gle.com>, erdemaktas@...gle.com,
        Connor Kuehl <ckuehl@...hat.com>,
        Sean Christopherson <seanjc@...gle.com>
Subject: Re: [RFC PATCH v5 024/104] KVM: TDX: create/destroy VM structure

On Tue, Apr 05, 2022 at 02:44:04PM +0200,
Paolo Bonzini <pbonzini@...hat.com> wrote:

> > diff --git a/arch/x86/kvm/vmx/main.c b/arch/x86/kvm/vmx/main.c
> > index 6111c6485d8e..5c3a904a30e8 100644
> > --- a/arch/x86/kvm/vmx/main.c
> > +++ b/arch/x86/kvm/vmx/main.c
> > @@ -39,12 +39,24 @@ static int vt_vm_init(struct kvm *kvm)
> >   		ret = tdx_module_setup();
> >   		if (ret)
> >   			return ret;
> > -		return -EOPNOTSUPP;	/* Not ready to create guest TD yet. */
> > +		return tdx_vm_init(kvm);
> >   	}
> >   	return vmx_vm_init(kvm);
> >   }
> > +static void vt_mmu_prezap(struct kvm *kvm)
> > +{
> > +	if (is_td(kvm))
> > +		return tdx_mmu_prezap(kvm);
> > +}
> 
> Please rename the function to explain what it does, for example
> tdx_mmu_release_hkid.

In the patch 021/104,  you suggested flush_shadow_all_private().
Which do you prefer? flush_shadow_all_private or tdx_mmu_release_hkid.
-- 
Isaku Yamahata <isaku.yamahata@...il.com>