linux-kernel - Re: [PATCH] drm/bridge: anx7625: Use uint8 for lane-swing arrays

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20848108-31bc-357c-224b-9cbdd465b195@collabora.com>
Date:   Fri, 8 Apr 2022 10:21:47 +0200
From:   AngeloGioacchino Del Regno 
        <angelogioacchino.delregno@...labora.com>
To:     Nícolas F. R. A. Prado 
        <nfraprado@...labora.com>, Robert Foss <robert.foss@...aro.org>,
        Neil Armstrong <narmstrong@...libre.com>,
        Andrzej Hajda <andrzej.hajda@...el.com>
Cc:     kernel@...labora.com, Daniel Vetter <daniel@...ll.ch>,
        David Airlie <airlied@...ux.ie>,
        Hsin-Yi Wang <hsinyi@...omium.org>,
        Jernej Skrabec <jernej.skrabec@...il.com>,
        Jonas Karlman <jonas@...boo.se>,
        Laurent Pinchart <Laurent.pinchart@...asonboard.com>,
        Maxime Ripard <maxime@...no.tech>,
        Pi-Hsun Shih <pihsun@...omium.org>,
        Sam Ravnborg <sam@...nborg.org>,
        Tzung-Bi Shih <tzungbi@...gle.com>,
        Xin Ji <xji@...logixsemi.com>, dri-devel@...ts.freedesktop.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drm/bridge: anx7625: Use uint8 for lane-swing arrays

Il 08/04/22 03:30, Nícolas F. R. A. Prado ha scritto:
> As defined in the anx7625 dt-binding, the analogix,lane0-swing and
> analogix,lane1-swing properties are uint8 arrays. Yet, the driver was
> reading the array as if it were of uint32 and masking to 8-bit before
> writing to the registers. This means that a devicetree written in
> accordance to the dt-binding would have its values incorrectly parsed.
> 
> Fix the issue by reading the array as uint8 and storing them as uint8
> internally, so that we can also drop the masking when writing the
> registers.
> 
> Fixes: fd0310b6fe7d ("drm/bridge: anx7625: add MIPI DPI input feature")
> Signed-off-by: Nícolas F. R. A. Prado <nfraprado@...labora.com>
> 

Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>