linux-kernel - Re: [PATCH v5 RESEND 0/3] Convert vmcore to use an iov

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Yk//TCkucXiVD3s0@MiWiFi-R3L-srv>
Date:   Fri, 8 Apr 2022 17:24:28 +0800
From:   Baoquan He <bhe@...hat.com>
To:     akpm@...ux-foundation.org, willy@...radead.org,
        Heiko Carstens <hca@...ux.ibm.com>
Cc:     linux-kernel@...r.kernel.org, kexec@...ts.infradead.org,
        hch@....de, yangtiezhu@...ngson.cn, amit.kachhap@....com,
        linux-fsdevel@...r.kernel.org, viro@...iv.linux.org.uk
Subject: Re: [PATCH v5 RESEND 0/3] Convert vmcore to use an iov_iter

Add Heiko to CC.

On 04/08/22 at 05:06pm, Baoquan He wrote:
> Copy the description of v3 cover letter from Willy:
> ===
> For some reason several people have been sending bad patches to fix
> compiler warnings in vmcore recently.  Here's how it should be done.
> Compile-tested only on x86.  As noted in the first patch, s390 should
> take this conversion a bit further, but I'm not inclined to do that
> work myself.

Forgot adding Heiko to CC again.

Hi Heiko,

Andrew worried you may miss the note, "As noted in the first patch,
s390 should take this conversion a bit further, but I'm not inclined
to do that work myself." written in cover letter from willy.

I told him you had already known this in v1 discussion. So add you in CC
list as Andrew required. Adding words to explain, just in case confusion.

> 
> V4:
> [PATCH v4 0/3] Convert vmcore to use an iov_iter
> https://lore.kernel.org/all/20220318093706.161534-1-bhe@redhat.com/T/#u
> 
> v3:
> [PATCH v3 0/3] Convert vmcore to use an iov_iter
> https://lore.kernel.org/all/20211213143927.3069508-1-willy@infradead.org/T/#u
> 
> 
> Changelog:
> ===
> v5 RESEND:
>  - Add my own Signed-off-by, no code or log change related in this round.
> 
> v5:
>  - Rebased on Linus's latest master branch.
>  - Merge the patch 4 of v4 into patch 2.
> v4:
>  - Append one patch to replace the open code with iov_iter_count().
>    This is suggested by Al.
>  - Fix a indentation error by replacing space with tab in
>    arch/sh/kernel/crash_dump.c of patch 1 reported by checkpatch. The
>    rest of patch 1~3 are untouched.
>  - Add Christopy's Reviewed-by and my Acked-by for patch 1~3.
> v3:
>  - Send the correct patches this time
> v2:
>  - Removed unnecessary kernel-doc
>  - Included uio.h to fix compilation problems
>  - Made read_from_oldmem_iter static to avoid compile warnings during the
>    conversion
>  - Use iov_iter_truncate() (Christoph)
> 
> 
> Matthew Wilcox (Oracle) (3):
>   vmcore: Convert copy_oldmem_page() to take an iov_iter
>   vmcore: Convert __read_vmcore to use an iov_iter
>   vmcore: Convert read_from_oldmem() to take an iov_iter
> 
>  arch/arm/kernel/crash_dump.c     |  27 +------
>  arch/arm64/kernel/crash_dump.c   |  29 +------
>  arch/ia64/kernel/crash_dump.c    |  32 +-------
>  arch/mips/kernel/crash_dump.c    |  27 +------
>  arch/powerpc/kernel/crash_dump.c |  35 ++-------
>  arch/riscv/kernel/crash_dump.c   |  26 +------
>  arch/s390/kernel/crash_dump.c    |  13 ++--
>  arch/sh/kernel/crash_dump.c      |  29 ++-----
>  arch/x86/kernel/crash_dump_32.c  |  29 +------
>  arch/x86/kernel/crash_dump_64.c  |  48 ++++--------
>  fs/proc/vmcore.c                 | 130 +++++++++++++------------------
>  include/linux/crash_dump.h       |  19 ++---
>  12 files changed, 123 insertions(+), 321 deletions(-)
> 
> -- 
> 2.34.1
>