linux-kernel - Re: [PATCH] drm/bridge: anx7625: Use irq flags from devicetree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <63867ed3-0c2a-207f-df91-ad1f6ec1d550@collabora.com>
Date:   Fri, 8 Apr 2022 12:15:44 +0200
From:   AngeloGioacchino Del Regno 
        <angelogioacchino.delregno@...labora.com>
To:     Nícolas F. R. A. Prado 
        <nfraprado@...labora.com>, Robert Foss <robert.foss@...aro.org>,
        Neil Armstrong <narmstrong@...libre.com>,
        Andrzej Hajda <andrzej.hajda@...el.com>
Cc:     kernel@...labora.com, Daniel Vetter <daniel@...ll.ch>,
        David Airlie <airlied@...ux.ie>,
        Hsin-Yi Wang <hsinyi@...omium.org>,
        Jernej Skrabec <jernej.skrabec@...il.com>,
        Jonas Karlman <jonas@...boo.se>,
        Laurent Pinchart <Laurent.pinchart@...asonboard.com>,
        Maxime Ripard <maxime@...no.tech>,
        Pi-Hsun Shih <pihsun@...omium.org>,
        Sam Ravnborg <sam@...nborg.org>,
        Tzung-Bi Shih <tzungbi@...gle.com>,
        Xin Ji <xji@...logixsemi.com>, dri-devel@...ts.freedesktop.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drm/bridge: anx7625: Use irq flags from devicetree

Il 08/04/22 03:33, Nícolas F. R. A. Prado ha scritto:
> Read the irq flags, like which edge to trigger on, from the devicetree
> and use those when registering the irq instead of hardcoding them.
> In case none was specified, fallback to falling edge trigger.
> 
> Signed-off-by: Nícolas F. R. A. Prado <nfraprado@...labora.com>
> 
> ---
> 
>   drivers/gpu/drm/bridge/analogix/anx7625.c | 8 ++++++--
>   1 file changed, 6 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/bridge/analogix/anx7625.c b/drivers/gpu/drm/bridge/analogix/anx7625.c
> index 6516f9570b86..97d954b8cc12 100644
> --- a/drivers/gpu/drm/bridge/analogix/anx7625.c
> +++ b/drivers/gpu/drm/bridge/analogix/anx7625.c
> @@ -2588,6 +2588,7 @@ static int anx7625_i2c_probe(struct i2c_client *client,
>   	struct anx7625_platform_data *pdata;
>   	int ret = 0;
>   	struct device *dev = &client->dev;
> +	unsigned long irqflags;
>   
>   	if (!i2c_check_functionality(client->adapter,
>   				     I2C_FUNC_SMBUS_I2C_BLOCK)) {
> @@ -2639,10 +2640,13 @@ static int anx7625_i2c_probe(struct i2c_client *client,
>   			goto free_hdcp_wq;
>   		}
>   
> +		irqflags = irq_get_trigger_type(client->irq);

Nicolas, this is not necessary... what are you trying to solve?

> +		if (!irqflags)
> +			irqflags = IRQF_TRIGGER_FALLING;

...and this is already done for you by __setup_irq(), check kernel/irq/manage.c.

> +
>   		ret = devm_request_threaded_irq(dev, platform->pdata.intp_irq,
>   						NULL, anx7625_intr_hpd_isr,
> -						IRQF_TRIGGER_FALLING |
> -						IRQF_ONESHOT,
> +						irqflags | IRQF_ONESHOT,
>   						"anx7625-intp", platform);
Partial devm_request_threaded_irq() flow, to make you understand what's going on:

devm_request_threaded_irq() -> request_threaded_irq() -> __setup_irq()


That said, congrats for solving that external display issue, but I'm sure that this
commit is not part of any solution and, if it is, you should recheck your machine's
DT, as the mistake must be there, then!

Cheers,
Angelo