[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20220408105242.GT3293@kadam>
Date: Fri, 8 Apr 2022 13:52:42 +0300
From: Dan Carpenter <dan.carpenter@...cle.com>
To: Kate Hsuan <hpa@...hat.com>
Cc: Sakari Ailus <sakari.ailus@...ux.intel.com>,
Bingbu Cao <bingbu.cao@...el.com>,
Tianshu Qiu <tian.shu.qiu@...el.com>,
Mauro Carvalho Chehab <mchehab@...nel.org>,
Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
Jean-Michel Hautbois <jeanmichel.hautbois@...asonboard.com>,
linux-media@...r.kernel.org, linux-staging@...ts.linux.dev,
linux-kernel@...r.kernel.org, hdegoede@...hat.com
Subject: Re: [PATCH v3] staging: media: ipu3: Fix AWB x_start position when
rightmost stripe is used
On Fri, Apr 08, 2022 at 06:42:22PM +0800, Kate Hsuan wrote:
> An not calibrated x_start setting would result in an incorrect AWB grid
> configuration on a sensor when only the rightmost stripe is used.
>
> If the AWB grid coordinate is set to the rightmost stripe, for example,
> x_start is greater than 640, the AWB grid will be at the rightmost edge of
> the sensor. The AWB statistic will be fetched from the wrong place of the
> sensor and results in an incorrect AWB estimation result. Therefore,
> stripe offset should subtract from x_start to have a correct grid
> configuration for the rightmost stripe.
>
Thank you!
regards,
dan carpenter
Powered by blists - more mailing lists