linux-kernel - Re: [PATCH] drm/amdgpu: Fix NULL pointer dereference

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAP+8YyED70CSqVRaB7JgrAtK-yvBx5EsvrrdR7EpvOG2AVhskQ@mail.gmail.com>
Date:   Fri, 8 Apr 2022 13:28:25 +0200
From:   Bas Nieuwenhuizen <bas@...nieuwenhuizen.nl>
To:     Simon Ser <contact@...rsion.fr>
Cc:     Grigory Vasilyev <h0tc0d3@...il.com>,
        Rodrigo Siqueira <Rodrigo.Siqueira@....com>,
        Melissa Wen <mwen@...lia.com>,
        Alex Deucher <alexander.deucher@....com>,
        Christian König <christian.koenig@....com>,
        "Pan, Xinhui" <Xinhui.Pan@....com>,
        David Airlie <airlied@...ux.ie>,
        Daniel Vetter <daniel@...ll.ch>,
        Michel Dänzer <mdaenzer@...hat.com>,
        Evan Quan <evan.quan@....com>,
        Sean Paul <seanpaul@...omium.org>,
        Qingqing Zhuo <qingqing.zhuo@....com>,
        amd-gfx mailing list <amd-gfx@...ts.freedesktop.org>,
        ML dri-devel <dri-devel@...ts.freedesktop.org>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] drm/amdgpu: Fix NULL pointer dereference

On Fri, Apr 8, 2022 at 12:01 PM Simon Ser <contact@...rsion.fr> wrote:
>
> Is amdgpu_display_get_fb_info ever called with NULL tiling_flags/tmz_surface?
> If not, there's no point in adding NULL checks.

It isn't called with NULL anywhere, the NULL checks that already exist
seem redundant.