linux-kernel - Re: [PATCH v2 2/3] tty: Add lookahead param to receive

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YlAjfAab+Oh3HcCR@smile.fi.intel.com>
Date:   Fri, 8 Apr 2022 14:58:52 +0300
From:   Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To:     Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>
Cc:     linux-serial@...r.kernel.org, Greg KH <gregkh@...uxfoundation.org>,
        Jiri Slaby <jirislaby@...nel.org>,
        linux-kernel@...r.kernel.org,
        Gilles Buloz <gilles.buloz@...tron.com>,
        Johan Hovold <johan@...nel.org>
Subject: Re: [PATCH v2 2/3] tty: Add lookahead param to receive_buf

On Fri, Apr 08, 2022 at 02:39:53PM +0300, Ilpo Järvinen wrote:
> After lookahead for XON/XOFF characters is added by the next
> patch, the receive side needs to ensure the flow-control
> actions are not retaken later on when those same characters
> get read by TTY.
> 
> Thus, pass lookahead count to receive_buf and skip
> flow-control character actions if already taken for the
> character in question. Lookahead count will become live after
> the next patch.

...

> +		if (c == STOP_CHAR(tty)) {
> +			if (!lookahead_done)

But now it can be as below

		if (c == STOP_CHAR(tty) && !lookahead_done)

> +				stop_tty(tty);
> +		} else if ((c == START_CHAR(tty) && !lookahead_done) ||
>  			 (tty->flow.stopped && !tty->flow.tco_stopped && I_IXANY(tty) &&
>  			  c != INTR_CHAR(tty) && c != QUIT_CHAR(tty) &&
>  			  c != SUSP_CHAR(tty))) {


-- 
With Best Regards,
Andy Shevchenko