linux-kernel - Re: [PATCH v1 2/2] net: usb: cdc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87ee27y9ym.fsf@miraculix.mork.no>
Date:   Fri, 08 Apr 2022 15:35:13 +0200
From:   Bjørn Mork <bjorn@...k.no>
To:     Lars Melin <larsm17@...il.com>
Cc:     sven@...nschwermer.de, linux-usb@...r.kernel.org,
        Sven Schwermer <sven.schwermer@...ruptive-technologies.com>,
        linux-kernel@...r.kernel.org, oliver@...kum.org
Subject: Re: [PATCH v1 2/2] net: usb: cdc_ether: Add Fibocom MA510 modem

Lars Melin <larsm17@...il.com> writes:

> Why do you add this modem to the whitelist?

I believe the clue is the

> +	.driver_info = (unsigned long)&wwan_info,

to set FLAG_WWAN instead of the default FLAG_ETHER | FLAG_POINTTOPOINT

> The net interface has the correct cdc_ether attributes so the
> cdc_ether driver should bind automagically without any need for the
> modem to be in the whitelist.

Yes, this sort of works against the class driver philosophy.  But we've
already started down that road, so...



Bjørn